Created attachment 8727 [details] [review] Bug 7859 - members/pay.pl plack scoping Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 112. Variable "$borrower" is not available at /srv/koha/members/pay.pl line 129. Variable "$input" is not available at /srv/koha/members/pay.pl line 142. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 157. Variable "$user" is not available at /srv/koha/members/pay.pl line 171. Variable "$input" is not available at /srv/koha/members/pay.pl line 172. Variable "$input" is not available at /srv/koha/members/pay.pl line 181. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 187. Variable "$branch" is not available at /srv/koha/members/pay.pl line 187. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 222. Variable "$input" is not available at /srv/koha/members/pay.pl line 239. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 246.
Test i did: i choose a borrower having fines. Going to fines page (members/boraccount.pl?borrowernumber=xx) and click on "Pay fines" tabs (members/pay.pl?borrowernumber=xx). Running koha on plack, fines don't appear in the page although there have. Applying the patch: it's ok, fines come back running koha either with plackup or startman. signing off
Created attachment 8765 [details] [review] [Signed-off] Bug 7859 - members/pay.pl plack scoping Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 112. Variable "$borrower" is not available at /srv/koha/members/pay.pl line 129. Variable "$input" is not available at /srv/koha/members/pay.pl line 142. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 157. Variable "$user" is not available at /srv/koha/members/pay.pl line 171. Variable "$input" is not available at /srv/koha/members/pay.pl line 172. Variable "$input" is not available at /srv/koha/members/pay.pl line 181. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 187. Variable "$branch" is not available at /srv/koha/members/pay.pl line 187. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 222. Variable "$input" is not available at /srv/koha/members/pay.pl line 239. Variable "$borrowernumber" is not available at /srv/koha/members/pay.pl line 246. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Just rescopes 'my' to 'our' which we've found to be harmless in CGI environments. Marking as Passed QA
There have been no further reports of problems so I am marking this bug resolved.