Right now, if extended patron attributes are enabled, all those fields are searched on when searching for patrons. A library using Koha should be able to use extended attributes without necessarily being able to search on them. Case in point, a library has created an extended attribute to store the cardnumbers of lost library cards. In the current system, anyone could walk in with a lost library card they found, and when the librarian scans it, that patron will pop up. Unless the librarian notices the number on the physical card is different than the one displayed on the screen, the unscrupulous person will be able to check out items on this lost card!
Created attachment 9375 [details] [review] Bug 8029 - Allow ExtendedPatronAttributes to *not* be searched when enabled. Right now, if extended patron attributes are enabled, all those fields are searched on when searching for patrons. A library using Koha should be able to use extended attributes without necessarily being able to search on them. Adds the system preference ExtendedPatronAttributesSearch, which will by default be set to the same value as ExtendedPatronAttributes, so upgrading will retain the same functionality.
Created attachment 9663 [details] [review] Bug 8092: Convert Koha::Cache to use CHI Implements cache handlers for Memcached, mmap shared-file persistent, and in-process memory caches. If CHI is unavailable, Koha::Cache::Memcached will fall back to using Cache::Memcached::Fast, or caching will be skipped without croaking. To test: run t/Cache.t with the following options, before and after installing CHI: 2. Tests 3-9 should be skipped with the following: export CACHING_SYSTEM= 2. You should receive two failures with the following if CHI is not installed: export CACHING_SYSTEM=memory 3. You should receive two failures with the following if CHI is not installed: export CACHING_SYSTEM=fastmmap 4. You will need memcached activated for the following to work (but it will work both with and without CHI): export CACHING_SYSTEM=memcached export MEMCACHED_SERVERS=127.0.0.1:11211 export MEMCACHED_NAMESPACE=KOHA 5. You should receive two failures with the following: export CACHING_SYSTEM=thisdoesntexist Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, now we need a follow up to add the new dependency.