Bug 8066 - action logs default value
Summary: action logs default value
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P3 normal
Assignee: Paul Poulain
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 09:21 UTC by Paul Poulain
Modified: 2014-12-07 20:03 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 8066 default values set to 0 for loging syspreferences (17.80 KB, patch)
2012-05-10 10:40 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2012-05-10 09:21:55 UTC
Bu default, most log systempreferences are ON. The consequence is that we get the action_logs table filled "silently".
It would be better to have those values set to OFF by default when installing a new Koha
Comment 1 Paul Poulain 2012-05-10 10:40:17 UTC
Created attachment 9499 [details] [review]
Bug 8066 default values set to 0 for loging syspreferences

Bu default, most log systempreferences are ON.
The consequence is that we get the action_logs table filled "silently".
It would be better to have those values set to OFF by default when installing a new Koha
Comment 2 Jared Camins-Esakov 2012-05-12 14:19:04 UTC
I disagree. I think most people expect the logs to be populated by default. Audit logs are a standard feature in ILSes. I think it's better to leave the default as it is, and if you would like to make sure people know that the logs are enabled by default, add a message to that effect during installation.
Comment 3 Katrin Fischer 2012-05-12 16:14:48 UTC
Hi Paul,

I think I agree with Jared here. 

An option, could be to make it part of the web installer. For example you could add a French system preferences file if there is none yet. I have one for German to change some of the default values. It could also be its own SQL file making the required change on demand.
Comment 4 Paul Poulain 2012-05-14 14:11:56 UTC
(In reply to comment #2)
> I disagree. I think most people expect the logs to be populated by default.

Most people who *know* there are logs expect them to be populated by default. However, small libraries, will never know. And I think it's much more harmfull to have them ON by default than to discover it would have been useful to have them ON and discover they're OFF ! If the cleaning was automatic, I wouldn't object. But it's not the case, and we have discovered that one of our small customer had ... 2 millions lines in this log, for a database of less than 10k items !
Comment 5 Chris Nighswonger 2012-05-14 14:19:59 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > I disagree. I think most people expect the logs to be populated by default.
> 
> Most people who *know* there are logs expect them to be populated by
> default. However, small libraries, will never know. And I think it's much
> more harmfull to have them ON by default than to discover it would have been
> useful to have them ON and discover they're OFF ! If the cleaning was
> automatic, I wouldn't object. But it's not the case, and we have discovered
> that one of our small customer had ... 2 millions lines in this log, for a
> database of less than 10k items !

I expect logs to be enabled by default. This is consistent with nearly 100% of software which I have had experience with, including all *nix packages.

I think that this is more of a training issue than a software issue. Train librarians/system admins to check/truncate/archive/whatever their logs and this problem will go a way.

I would not be opposed to some sort of auto-archiving feature similar to what *nix logs typically have.

My $0.02 worth...
Comment 6 Katrin Fischer 2012-05-15 07:34:13 UTC
What about making it a choice with explanation at install time? I think an additional SQL file for the webinstaller shoudl work here. It would inform the libraries about the logs and give an option to turn them off.
Or we could add a script to the cronjobs to clean the log tables regularly?
Comment 7 Magnus Enger 2012-05-15 07:46:18 UTC
I agree with Katrin et al. I expect logging to be on by default. 

And I disagree with Paul: I think "to discover it would have been useful to have them ON and discover they're OFF" would be worse than taking up some extra database space. 

Creating an SQL file for the webinstaller that makes it possible to choose to turn logging off during installation would be a good workaround, though. Something like:

UPDATE systempreferences SET value = 0 WHERE variable = 'IssueLog';
etc...
Comment 8 Paul Poulain 2012-06-10 14:19:48 UTC
OK, won't argue more and accept letting the syspref to 1