Images of covers must preserve transparency of png-images. This is useful for example for the covers of CD/DVD disks.
Created attachment 9573 [details] [review] Small changes in C4/Images.pm Replace my $newimage = $image->clone; by my $newimage = GD::Image->new( $width_reduce, $height_reduce, 1 ); $newimage->alphaBlending(0); $newimage->saveAlpha(1);
I like the idea, but do we need the commented out transparency lines? Can we safely remove those?
Still waiting on answer to the question before signoff
(In reply to comment #2) > I like the idea, but do we need the commented out transparency lines? > > Can we safely remove those? Yes.
Still valid?
After few years, this still an issue. ;-)
Created attachment 175852 [details] Transparent image
Created attachment 175853 [details] [review] Bug 8088: Png-images of covers lost transparency Images of covers must preserve transparency of png-images. This is useful for example for the covers of CD/DVD disks. Plan test : 1. Apply the patch. 2. In 'Koha administration > System preferences', set 'LocalCoverImages' to 'show' and OPACLocalCoverImages to 'show'. 3. Create a new bibligraphical record 4. In the record details select tab Images and click on upload 5. click on « Drop files here » and select the image file to upload then click «Process images» 6. Search for the record created on step 3 7. Click on the record to view detail page (detail.pl) 8. Click on the image to view it fully --->Notice the background is transparent 9. Save the image and open it ---> Notice the background is transparent
Created attachment 175964 [details] [review] Bug 8088: Png-images of covers lost transparency Images of covers must preserve transparency of png-images. This is useful for example for the covers of CD/DVD disks. Plan test : 1. Apply the patch. 2. In 'Koha administration > System preferences', set 'LocalCoverImages' to 'show' and OPACLocalCoverImages to 'show'. 3. Create a new bibligraphical record 4. In the record details select tab Images and click on upload 5. click on « Drop files here » and select the image file to upload then click «Process images» 6. Search for the record created on step 3 7. Click on the record to view detail page (detail.pl) 8. Click on the image to view it fully --->Notice the background is transparent 9. Save the image and open it ---> Notice the background is transparent Signed-off-by: esther <esther@bywatersolutions.com>
The image retained transparency after uploading. Also checked the OPAC and the image had transparency.
Created attachment 176278 [details] [review] Bug 8088: (follow-up) keep image transparency when importing a batch of cover images Images of covers must preserve transparency of png-images when uploading a batches of images in a ZIP file Plan test : Make sure you have a valid Zip file that contains the images to upload and a valid datalink.txt or idlink.txt file 1. Apply the patch. 2. In 'Cataloging > Upload local cover image', set 'LocalCoverImages' to 'show' and OPACLocalCoverImages to 'show'. 3. Click on « Drop files here » and select the ZIP file to upload then click «Process images» 6. For each notice check the transparency of images --->Notice the background is transparent
Created attachment 176536 [details] [review] Bug 8088: Png-images of covers lost transparency Images of covers must preserve transparency of png-images. This is useful for example for the covers of CD/DVD disks. Plan test : 1. Apply the patch. 2. In 'Koha administration > System preferences', set 'LocalCoverImages' to 'show' and OPACLocalCoverImages to 'show'. 3. Create a new bibligraphical record 4. In the record details select tab Images and click on upload 5. click on « Drop files here » and select the image file to upload then click «Process images» 6. Search for the record created on step 3 7. Click on the record to view detail page (detail.pl) 8. Click on the image to view it fully --->Notice the background is transparent 9. Save the image and open it ---> Notice the background is transparent
Created attachment 176537 [details] [review] Bug 8088: Png-images of covers lost transparency Images of covers must preserve transparency of png-images. This is useful for example for the covers of CD/DVD disks. Plan test : 1. Apply the patch. 2. In 'Koha administration > System preferences', set 'LocalCoverImages' to 'show' and OPACLocalCoverImages to 'show'. 3. Create a new bibligraphical record 4. In the record details select tab Images and click on upload 5. click on « Drop files here » and select the image file to upload then click «Process images» 6. Search for the record created on step 3 7. Click on the record to view detail page (detail.pl) 8. Click on the image to view it fully --->Notice the background is transparent 9. Save the image and open it ---> Notice the background is transparent
This looks like it's working correctly but please run the qa script on it and fix the errors it reports.
We don't have the sponsor for this anymore. Resetting the assignee to default.
Created attachment 191023 [details] [review] Bug 8088: Png-images of covers lost transparency Images of covers must preserve transparency of png-images. This is useful for example for the covers of CD/DVD disks. Plan test : 1. Apply the patch. 2. In 'Koha administration > System preferences', set 'LocalCoverImages' to 'show' and OPACLocalCoverImages to 'show'. 3. Create a new bibligraphical record 4. In the record details select tab Images and click on upload 5. Click on « Drop files here » and select the image file to upload then click «Process images» 6. Search for the record created on step 3 7. Click on the record to view detail page (detail.pl) 8. Click on the image to view it fully ---> Notice the background is transparent 9. Save the image and open it ---> Notice the background is transparent Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 191024 [details] [review] Bug 8088: (follow-up) Tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org>