DataTables in Acquisision module: neworderbiblio.tt
Created attachment 9606 [details] [review]
Comment from Bug 5345:
8) neworderbiblio.tt - still applies on current master. There is still a pagination on top of the page. I think sorting only a single result page does not make sense. We should remove the pagination in favor of the datatables or keep pagination for now. FAILED QA
Katrin and Owen, this bug comes from bug 5345 and has a comment related to a comment you made on the bug 5345, so adding you to this bug
Created attachment 9781 [details] [review]
[PATCH 08/16] Bug 5345: DataTables integration in acquisition module 
I am not sure what this patch does.
I think it changes the result list for when you are searching for an existing record?
I can see it adds zebra striping to the table, but there seem to be no options for sorting and the old pagination is still in place.
Yes, this patch adds datatable but without sort, filters and pagination.
Well, in that case it's all ok :) Sign off coming.
Created attachment 10198 [details] [review]
[SIGNED-OFF] Bug 8100: DataTables integration in acquisition module 
Signed-off-by: Katrin Fischer <Katrin.Fischer.email@example.com>
Fixed bug number.
Template only change, includes JS, CSS, and includes strings. Minor table structure fixes. Marking Passed QA.
There have been no further reports of problems so I am marking this bug resolved.