Bug 8143 - Upgrade jQuery tabs to current jQueryUI version
Summary: Upgrade jQuery tabs to current jQueryUI version
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on: 7747 8229
Blocks: 5481 8181
  Show dependency treegraph
 
Reported: 2012-05-23 16:21 UTC by Owen Leonard
Modified: 2013-12-05 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8143 - Upgrade jQuery tabs to current jQueryUI version (257.55 KB, patch)
2012-06-01 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version (257.54 KB, patch)
2012-06-05 15:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version (257.60 KB, patch)
2012-06-10 10:49 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version (256.98 KB, patch)
2012-06-10 11:07 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 8143: Follow up - Fixing tabs when editing subfields (1.54 KB, patch)
2012-06-16 13:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-05-23 16:21:47 UTC
We use a very old version of jQuery tabs in many places. Each instance should be updated to work with the latest jQueryUI.
Comment 1 Owen Leonard 2012-06-01 16:22:19 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-06-05 15:47:55 UTC
This patch touches a lot of files, so I thought it might be helpful to list the pages which should be checked. In this first list, these are pages which can be viewed to check changes to include files. On each of these pages the search header include was modified:

acquisitions-search.inc:
  acqui/acqui-home.pl
authorities-search.inc:
  authorities/authorities-home.pl
budgets-admin-search.inc:
  admin/aqbudgetperiods.pl
cat-search.inc:
  virtualshelves/shelves.pl
cataloging-search.inc:
  cataloguing/addbooks.pl
checkin-search.inc:
  circ/returns.pl
circ-search.inc:
  circ/circulation-home.pl
cities-admin-search.inc:
  admin/cities.pl
contracts-admin-search.inc:
  admin/aqcontract.pl?booksellerid=1
currencies-admin-search.inc:
  admin/currency.pl
home-search.inc:
  mainpage.pl
letters-search.inc:
  tools/letter.pl
patron-search.inc:
  members/members-home.pl
patrons-admin-search.inc:
  admin/categorie.pl
prefs-admin-search.inc:
  admin/preferences.pl
printers-admin-search.inc:
  admin/printers.pl
roadtype-admin-search.inc:
  admin/roadtype.pl
serials-search.inc:
  serials/serials-home.pl
stopwords-admin-search.inc:
  admin/stopwords.pl
suggestions-add-search.inc:
  acqui/newordersuggestion.pl?booksellerid=1&basketno=1
sysprefs-admin-search.inc:
  admin/systempreferences.pl
z3950-admin-search.inc:
  admin/z3950servers.pl

These pages have changes to their main templates:

about.pl
acqui/basketgroup.pl
admin/auth_subfields_structure.pl
admin/authorised_values.pl
admin/branch_transfer_limits.pl
admin/item_circulation_alerts.pl
admin/itemtypes.pl
admin/marc_subfields_structure.pl
authorities/authorities.pl
authorities/detail.pl
catalogue/MARCdetail.pl
catalogue/advsearch.pl
catalogue/detail.pl
cataloguing/addbiblio.pl
cataloguing/merge.pl
circ/circulation.pl
circ/waitingreserves.pl
members/boraccount.pl
members/mancredit.pl
members/maninvoice.pl
members/moremember.pl
members/pay.pl
members/paycollect.pl
reviews/reviewswaiting.pl
serials/serials-collection.pl
serials/subscription-detail.pl
suggestion/suggestion.pl
tools/csv-profiles.pl
tools/overduerules.pl
virtualshelves/shelves.pl
opac-advsearch.pl
opac-detail.pl
opac-readingrecord.pl
opac-user.pl
Comment 3 Owen Leonard 2012-06-05 15:53:08 UTC Comment hidden (obsolete)
Comment 4 Michael Davis 2012-06-10 09:03:45 UTC
error: patch failed: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:29
error: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: patch does not apply
Comment 5 Martin Renvoize 2012-06-10 10:00:22 UTC
Applies cleanly to master for me... changing status to Needs Signoff
Comment 6 Michael Davis 2012-06-10 10:23:53 UTC
Doesn't apply if you add the 7747 patch first, which I assume is needed as it's listed as a dependency. Adding this patch only breaks the tabs, for instance on cataloguing/addbiblio.pl
Comment 7 Martin Renvoize 2012-06-10 10:49:34 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2012-06-10 10:52:46 UTC
Good catch Michael, I'de missed the dependency..  Will re-test/re-base as needed now.
Comment 9 Martin Renvoize 2012-06-10 11:07:51 UTC
Created attachment 10084 [details] [review]
Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version

Now applied after bug7747, still seems to apply cleanly for me?
Comment 10 Martin Renvoize 2012-06-10 12:47:01 UTC
Michael, what exactly do you mean by "breaks tabs".. for example on cataloguing/addbiblio.pl  

I'm seeing perfect normal operation.. Wondering if I have something cached somewhere or similar and am there for not seeing the effect of the patch?
Comment 11 Michael Davis 2012-06-10 13:29:51 UTC
(In reply to comment #10)
> Michael, what exactly do you mean by "breaks tabs".. for example on
> cataloguing/addbiblio.pl  
> 
> I'm seeing perfect normal operation.. Wondering if I have something cached
> somewhere or similar and am there for not seeing the effect of the patch?

The tabs are not styled as tabs, but appearing as an unstyled ul list. This should be styled by the jquery-ui.css, so either I'm not getting this when I should, or you're getting it when you shouldn't. Could be a caching issue.
Comment 12 Paul Poulain 2012-06-10 13:32:01 UTC
QA comment:
very large patch, but most of it is the new version of jquery tab.
Changes in templates are all the same, changing links and tab declaration.

I checked some pages and couldn't see anything wrong.
No reason to object passed QA, even if, due to the size of the patch, I haven't checked everything !
Comment 13 Paul Poulain 2012-06-10 13:35:18 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > Michael, what exactly do you mean by "breaks tabs".. for example on
> > cataloguing/addbiblio.pl  
> > 
> > I'm seeing perfect normal operation.. Wondering if I have something cached
> > somewhere or similar and am there for not seeing the effect of the patch?
> 
> The tabs are not styled as tabs, but appearing as an unstyled ul list. This
> should be styled by the jquery-ui.css, so either I'm not getting this when I
> should, or you're getting it when you shouldn't. Could be a caching issue.

OK, checked with Michael, seems it was a FF cache issue, will push
Comment 14 Katrin Fischer 2012-06-16 13:00:25 UTC Comment hidden (obsolete)
Comment 15 Katrin Fischer 2012-06-16 13:02:15 UTC
Comment on attachment 10322 [details] [review]
Bug 8143: Follow up - Fixing tabs when editing subfields

Missed there is already a patch on bug 8229 :)
Comment 16 Jared Camins-Esakov 2012-12-31 01:06:25 UTC
There have been no further reports of problems so I am marking this bug resolved.