Bug 8258 - Branch specific DUEDGST notice is not used
Summary: Branch specific DUEDGST notice is not used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-17 14:43 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST (3.62 KB, patch)
2014-03-05 14:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST (3.68 KB, patch)
2014-03-07 18:50 UTC, Kyle M Hall
Details | Diff | Splinter Review
0001-PASSED-QA-Bug-8258-Use-patron-branchcode-notice-for-.patch (4.29 KB, patch)
2014-04-20 09:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST (4.29 KB, patch)
2014-04-20 15:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2012-06-17 14:43:53 UTC
While testing bug 3383 I noticed, that it's possible to add branch specific DUEDGST notices, but they are not used when generating notices. Instead the notice for (All libraries) was being used.

My patron's home library was Midway, books were checked out from Midway and another library.
Comment 1 Katrin Fischer 2014-02-20 16:12:17 UTC
I repeated this test today with PREDUEDGST and it's the same result: We print the branch information from the patron's branch, but it's not using the notice template from the patron's branch but the general template.
Comment 2 Jonathan Druart 2014-03-05 14:22:05 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-03-07 18:50:22 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-04-20 09:10:51 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-04-20 15:03:13 UTC
Created attachment 27323 [details] [review]
[PASSED QA] Bug 8258: Use patron branchcode notice for DUEDGST and PREDUEDGST

If a notice is defined for the branchcode of the patron, it should be
used.
Without this patch, the notice used is the one defined for all
libraries.

Test plan:
1/ Set the advanced notice for a patron using digest.
2/ Check one item out to this patron (backdate the return date according
the days in advance value).
3/ launch advance_notices.pl -c
4/ Verify the notice used is the default one.
5/ Define a notice for the library of the patron for PREDUEDGST
6/ launch advance_notices.pl -c
7/ Verify the notice used is the one previously defined.
8/ Check one item out to this patron (date due = today)
9/ launch advance_notices.pl -c
10/ Verify the notice used is the default one.
11/ Define a notice for the library of the patron for DUEDGST
12/ launch advance_notices.pl -c
13/ Verify the notice used is the one previously defined.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests  and QA script.
Test case: User from Library A, checked out books
- in library A from A and B
- in library B from B
Verified, that the 'all libraries' notice is still used,
when no specific notice is defined.
Verified, that the patron's home library noticed is used,
when defined.

Note: Before and after the patch we print the branch information
from the patron's home library, so also using the template from
this branch, seems logical. All items over all branches are
processed into one single reminder email, before and after the patch.
Comment 6 Galen Charlton 2014-04-20 15:24:47 UTC
Pushed to master.  Thanks, Jonathan!
Comment 7 Fridolin Somers 2014-08-13 07:56:50 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 8 Kyle M Hall 2014-08-13 18:34:22 UTC
Picked for 3.12.15!