Bug 8287 - remove filter on checked out from overdues
Summary: remove filter on checked out from overdues
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Target Milestone: ---
Assignee: Bugs List
QA Contact:
URL: /cgi-bin/koha/circ/overdue.pl
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-21 17:57 UTC by Nicole C. Engard
Modified: 2015-05-24 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-06-21 17:57:46 UTC
On the Overdues report there is a filter for "Show any items currently checked out:" ... but everything that is overdue should be checked out - so what does this do? If it does nothing then it should be removed. If it does something please tell me and I'll update the manual and we can close this.


Chat:

[13:45]  <nengard> question about overdue report
[13:45]  <nengard> can anyone tell me on this page: /cgi-bin/koha/circ/overdue.pl what does "Show any items currently checked out:" do?
[13:45]  <nengard> it's one of the filters on the left
[13:47]  <cait> not sure actually :(
[13:47]  <cait> shouldn't they all be checked out?
[13:47]  <nengard> right
[13:47]  <nengard> hence my confusion
[13:52]  <cait> no idea
[13:54]  <nengard> HA
[13:54]  <nengard> anyone else? should we remove it if it doesn't do anything?
Comment 1 Owen Leonard 2012-06-21 18:19:38 UTC
Here's the SQL for what is run without the box checked:

SELECT date_due, borrowers.title as borrowertitle, borrowers.surname, borrowers.firstname, borrowers.streetnumber, borrowers.streettype, borrowers.address, borrowers.address2, borrowers.city, borrowers.zipcode, borrowers.country, borrowers.phone, borrowers.email, issues.itemnumber, issues.issuedate, items.barcode, biblio.title, biblio.author, borrowers.borrowernumber, biblio.biblionumber, borrowers.branchcode, items.itemcallnumber, items.replacementprice, items.enumchron FROM issues LEFT JOIN borrowers ON (issues.borrowernumber=borrowers.borrowernumber ) LEFT JOIN items ON (issues.itemnumber=items.itemnumber) LEFT JOIN biblioitems ON (biblioitems.biblioitemnumber=items.biblioitemnumber) LEFT JOIN biblio ON (biblio.biblionumber=items.biblionumber ) WHERE 1=1 AND date_due < '2012-06-21 14:16' ORDER BY date_due, surname, firstname 

Here's the SQL with the box checked:

SELECT date_due, borrowers.title as borrowertitle, borrowers.surname, borrowers.firstname, borrowers.streetnumber, borrowers.streettype, borrowers.address, borrowers.address2, borrowers.city, borrowers.zipcode, borrowers.country, borrowers.phone, borrowers.email, issues.itemnumber, issues.issuedate, items.barcode, biblio.title, biblio.author, borrowers.borrowernumber, biblio.biblionumber, borrowers.branchcode, items.itemcallnumber, items.replacementprice, items.enumchron FROM issues LEFT JOIN borrowers ON (issues.borrowernumber=borrowers.borrowernumber ) LEFT JOIN items ON (issues.itemnumber=items.itemnumber) LEFT JOIN biblioitems ON (biblioitems.biblioitemnumber=items.biblioitemnumber) LEFT JOIN biblio ON (biblio.biblionumber=items.biblionumber ) WHERE 1=1 ORDER BY date_due, surname, firstname

Checking the box removes the limit on date_due.
Comment 2 Nicole C. Engard 2012-10-21 13:37:59 UTC
So, then maybe that box needs to say "Ignore Due-Date filter above" instead - or something more accurate.

Nicole
Comment 3 Owen Leonard 2013-08-08 16:36:17 UTC
(In reply to Nicole C. Engard from comment #2)
> So, then maybe that box needs to say "Ignore Due-Date filter above" instead
> - or something more accurate.

The checkbox basically switches this from a report of overdues to a report of checkouts. "Show all checkouts regardless of date due" might be more accurate? It's a strange feature to include in a report for showing overdues.

If you check the box the title of the report really should change to reflect that it's showing more than just overdues.
Comment 4 Jonathan Druart 2015-03-31 14:01:23 UTC
What could be a correct wording for the checkbox label and the page/report title?
Comment 5 Katrin Fischer 2015-05-24 22:26:16 UTC
Hm, what about:

- move the filter below the due date filter box
- "grey out" or deactivate due date filter visibly, whenever the checkbox is checked

?