Bug 8298 - Can't call method "subfield" on an undefined value at Biblio.pm (sub _AddBiblioNoZebra)
Summary: Can't call method "subfield" on an undefined value at Biblio.pm (sub _AddBibl...
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-23 08:12 UTC by Marc Véron
Modified: 2014-12-07 20:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2012-06-23 08:12:13 UTC
Koha version: 3.09.00.017

Error message:
Can't call method "subfield" on an undefined value at
 /usr/share/koha/lib/C4/Biblio.____pm line 2965.

Reported on koha@lists.katipo.co.nz , 23.June 2012

Occurs in sub _AddBiblioNoZebra
  
called by sub ModZebra. Line 2730  ((if preference "NoZebra" is set))

Line 2730: 
 %result = _AddBiblioNoZebra( $biblionumber, $newRecord, $server, %result );

It seems, that $newRecord is not defined, leading to error message above.

See comment on line 2700: " $newRecord is the MARC::Record containing the new record. It is usefull only when NoZebra=1, (...) "

Workaround: 
----------
Set system preference "NoZebra" to "Use"

Questions: 
--------
- Should Preference "NoZebra" be removed (since it is depracated and seems to be broken)
or
- Should the bug be tracked down ($newRecord not defined)?

Marc
Comment 1 Chris Cormack 2012-06-23 08:16:18 UTC
Yes, the preference should be removed. It has been deprecated for a while, the only reason it hasn't been removed is that if someone has it set in the db, once you remove it, they can't easily switch it back to zebra. (Unless they know to use the localuse tab)

But it should definitely be removed, and no time should be invested in making nozebra work again.
Comment 2 Marc Véron 2012-06-23 08:59:17 UTC
What about a warning section e.g. on the page "About Koha" similar to "Server Information", where such things could be indicated?

It would test for configuration glitches and show messages like:

Warning: "Deprecated System preference 'NoZebra' set.

I can imagine that there are other things that could be addressed this way as well.
Comment 3 Jared Camins-Esakov 2012-07-19 21:32:12 UTC
Marking as WONTFIX. A patch to alert people if they have NoZebra has already been submitted.