StatisticsFields says "___ Define Fields (from the items table) used for statistics members (separate fields with |, for example:"location|itype|ccode")." Originally I thought this was related to the statistical member type - so I recommend the following language change for this preference: "Show the following fields from the items database table as columns on the statistics tab on the patron record: ___ (separate fields with |)" Patch to follow.
Created attachment 10511 [details] [review] Bug 8318: Update StatisticsFields preference language This patch changes around the wording of the StatisticsFields preference to make it clearer where these values will show.
Created attachment 10534 [details] [review] [SIGNED-OFF] Bug 8318: Update StatisticsFields preference language This patch changes around the wording of the StatisticsFields preference to make it clearer where these values will show. Signed-off-by: Marc Veron <veron@veron.ch>
Changes the description for the syspref StatisticsFields Marking as Passed QA
mmm... the patch does not apply, probably because I fixed the yaml syntax recently. Could you rebase & resubmit, I don't want to do a mistake (directly passed QA status)
Paul, I just did a fetch from master and applied the patch just fine ... nengard@kohavm:~/kohaclone$ git bz apply 8318 Bug 8318 - update StatisticsFields description [SIGNED-OFF] Bug 8318: Update StatisticsFields preference language Apply? [yn] y Applying: Bug 8318: Update StatisticsFields preference language nengard@kohavm:~/kohaclone$
(In reply to comment #5) > Paul, > > I just did a fetch from master and applied the patch just fine ... ??? That's strange, I get the following conflict: 134 <<<<<<< HEAD 135 - Define Fields (from the items table) used for statistics members (separate fields with |, for example :"location|itype|ccode"). 136 - 137 - pref: EnableBorrowerFiles 138 choices: 139 yes: Do 140 no: "Don't" 141 - enable the ability to upload and attach arbitrary files to a borrower record. 142 ======= 143 - (separate fields with |) 144 >>>>>>> Bug 8318: Update StatisticsFields preference language I've rewritten you patch, and pushed, this will remain a mistery
There have been no further reports of problems so I am marking this bug resolved.