Bug 8318 - update StatisticsFields description
Summary: update StatisticsFields description
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low minor (vote)
Assignee: Nicole C. Engard
QA Contact:
URL:
Keywords:
Depends on: 7955
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-26 14:38 UTC by Nicole C. Engard
Modified: 2013-12-05 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8318: Update StatisticsFields preference language (1.35 KB, patch)
2012-06-26 14:40 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8318: Update StatisticsFields preference language (1.44 KB, patch)
2012-06-27 06:50 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-06-26 14:38:06 UTC
StatisticsFields says "___ Define Fields (from the items table) used for statistics members (separate fields with |, for example:"location|itype|ccode")."


Originally I thought this was related to the statistical member type - so I recommend the following language change for this preference:


"Show the following fields from the items database table as columns on the statistics tab on the patron record:  ___ (separate fields with |)"


Patch to follow.
Comment 1 Nicole C. Engard 2012-06-26 14:40:14 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2012-06-27 06:50:25 UTC
Created attachment 10534 [details] [review]
[SIGNED-OFF] Bug 8318: Update StatisticsFields preference language

This patch changes around the wording of the StatisticsFields
preference to make it clearer where these values will show.

Signed-off-by: Marc Veron <veron@veron.ch>
Comment 3 Jonathan Druart 2012-06-27 08:30:25 UTC
Changes the description for the syspref StatisticsFields

Marking as Passed QA
Comment 4 Paul Poulain 2012-06-28 12:08:20 UTC
mmm... the patch does not apply, probably because I fixed the yaml syntax recently. Could you rebase & resubmit, I don't want to do a mistake (directly passed QA status)
Comment 5 Nicole C. Engard 2012-06-28 14:30:15 UTC
Paul,

I just did a fetch from master and applied the patch just fine ...

nengard@kohavm:~/kohaclone$ git bz apply 8318
Bug 8318 - update StatisticsFields description

[SIGNED-OFF] Bug 8318: Update StatisticsFields preference language
Apply? [yn] y

Applying: Bug 8318: Update StatisticsFields preference language
nengard@kohavm:~/kohaclone$
Comment 6 Paul Poulain 2012-06-29 14:47:55 UTC
(In reply to comment #5)
> Paul,
> 
> I just did a fetch from master and applied the patch just fine ...
??? That's strange, I get the following conflict:
134 <<<<<<< HEAD
135          - Define Fields (from the items table) used for statistics members (separate fields with |, for example    :"location|itype|ccode").
136      -
137          - pref: EnableBorrowerFiles
138            choices:
139                yes: Do
140                no: "Don't"
141          - enable the ability to upload and attach arbitrary files to a borrower record.
142 =======
143          - (separate fields with |)
144 >>>>>>> Bug 8318: Update StatisticsFields preference language


I've rewritten you patch, and pushed, this will remain a mistery
Comment 7 Jared Camins-Esakov 2012-12-31 01:17:21 UTC
There have been no further reports of problems so I am marking this bug resolved.