If one wishes to customize the login screen of the staff client, CSS changes to div#login also affect the control set in the top menu bar. The top menu bar needs a different id name.
Created attachment 10575 [details] [review]
changed from login to login_controls in header.inc and staff-global.css
I was wondering how this might affect other languages, as I was only testing English. Similar changes would need to be made for them, as header.inc and staff-global.css are in language dependent subdirectories. This would patch English. Perhaps login_controls isn't a good enough name? I'm open to something else, as long as it isn't login. Thank you.
You only have to correct the English files, all other languages are created from those files and the translations in the po files.
The name is fine, but the change in id breaks the header layout once you are logged in on Chrome under Mac. The alignment is off.
Created attachment 11951 [details] [review]
Changed login to login_controls in header.inc and patched staff-global.css
This should not cause any strange repositioning of the control set in the header div on the right. It may not be pixel identical, but generally should not look vastly different.
Tested on my git dev master using Firefox 15 and IE 9. Sorry, I'm not installing Chrome too, jcamins. ;)
(In reply to comment #4)
> This should not cause any strange repositioning of the control set in the
> header div on the right. It may not be pixel identical, but generally should
> not look vastly different.
It doesn't have to look different at all! Instead of adding a new definition for #login_controls, change the ID of the original declaration for #login at line 161:
position : absolute;
right : .5em;
Change #login to #login_controls.
The Koha login form will be unaffected because there is a separate stylesheet which defines #login for that page.
The problem is the way cascading works. Renaming in place won't work. It needs to be below the ".clearfix" class. I was struggling for hours when I renamed in place, all because of the .clearfix class. I could put it in front of the #login_controls at the top if I wanted it in place, but it made more sense to be located with the other class that shares the header div.
And to follow up... because it is before the .clearfix class definition. The current #login unpatched does nothing, as far as I can tell.
Created attachment 12141 [details] [review]
Renamed login to login_controls in header.inc and staff-global.css
Caching of CSS files is a testing nightmare!
2) firebug the top right section div, it should be "login".
2) firebug the top right section div, it should be "login_controls".
WARNING: Make sure to trigger a reload of the CSS, otherwise a stale cache will have to screaming for hours.
Created attachment 12146 [details] [review]
[SIGNED-OFF] Bug 8339 - div id="login" should be id="login_controls" in header.inc
After experiencing what I believe was stale CSS, I have
implemented oleonard's suggested fix which does work. That is:
header.inc change login to login_controls, and in
staff-global.css change the #login to #login_controls.
Signed-off-by: Owen Leonard <email@example.com>
The template file modules/auth.tt still use the login id for a div element.
Please clarify if it is normal.
Marked as Failed QA.
That's exactly the point. It removes the ambiguity between what <div id="login"> refers to. The <div> on auth.tt will now be identified differently than the <div> in the staff client header.
(In reply to comment #11)
> That's exactly the point. It removes the ambiguity between what <div
> id="login"> refers to. The <div> on auth.tt will now be identified
> differently than the <div> in the staff client header.
Ok thank you Owen.
So I marked it as Passed QA.
Patch pushed to master
Pushed to 3.8.x will be in 3.8.5