There are problems the xslt file for Unimarc Opac detailed dysplay. 1) The title has '<h1> ... </h1>' instead of ''<h1 class="title"> ... </h1>' (line 29). 2)There are lines (71-86) that create link to different views of the record. But those links are created also with template opac-detail.tt. So in the display you see two time the same links. Those problems are present also in master and in 3.6
Created attachment 11154 [details] [review] Proposed patch Added "title" class. Removed view tabs. + Added exclude-result-prefixes in intranet UNIMARCslimUtils.xsl to avoid name spaces in HTML output (like in opac one).
Note that the "title" class is important because is sets the CSS float:none instead of float:left (like page without XSTL).
Created attachment 11188 [details] [review] Proposed patch (2) Added removal of the variable on 'viewISBD' syspref. It is useless in OPAC, it is dedicated to staff client.
I have test the patch with sandbox n.2. In fact the files are identical in 3.8.x and in master. No problem apply thr patch. With the patch the bug is over.
Patch tested with a sandbox, by Zeno Tajoli <tajoli@cilea.it>
Created attachment 11268 [details] [review] Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Zeno Tajoli <tajoli@cilea.it>
Comment on attachment 11188 [details] [review] Proposed patch (2) This patch signed-off by zeno. The other obsoleted patch ( Bug 8204: fix UNIMARC display (13.66 KB, patch) ) is a mistake made by the sandbox system.
But, signed-off patch is not in attachments. Zeno ?
Created attachment 11269 [details] [review] Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Zeno Tajoli <tajoli@cilea.it> http://bugs.koha-community.org/show_bug.cgi?id=8357 Signed-off-by: Zeno Tajoli <tajoli@cilea.it>
Sorry for the problem, I think there is same problem on sanboxes. I try to redo again
Created attachment 11270 [details] [review] Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views Signed-off-by: Zeno Tajoli <tajoli@cilea.it>
Hi to all, now the situation is OK. I don't know if is my work with sandbox number 3 or by Paul Poulain but it is OK.
(In reply to comment #14) > Hi to all, > > now the situation is OK. > I don't know if is my work with sandbox number 3 or by Paul Poulain but it > is OK. Well, the explanation is the following: * there was a mistake in my sandbox setup that made the signoff script to badly fail to do anything. * 2 days later, when I fixed the problem, your pending "sign-off" has been applied. Except that ... the signoff is made on the top patch. As 2 days have ellapsed, the "head" patch was no more the correct one and another one was attached as signed off ! My fault, but now it's fixed. The patch, signed-off by you, is uploaded !
(In reply to comment #10) > Created attachment 11269 [details] [review] > Bug 8204: fix UNIMARC display > > UNIMARC display of authorities in the OPAC wasn't working due to > changes in the BuildSummary function since the code was originally > developed. > > Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> > Signed-off-by: Zeno Tajoli <tajoli@cilea.it> patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 442dae6 Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK
Pushed to 3.8.x will be in 3.8.4
Pushed to master. Already on stable, setting status accordingly