Bug 8395 - order receive not sorting right
Summary: order receive not sorting right
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-09 16:30 UTC by Nicole C. Engard
Modified: 2013-12-05 20:05 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
not sorted (68.96 KB, image/png)
2012-07-09 16:30 UTC, Nicole C. Engard
Details
Bug 8395: Fix sort order in parcel.tt (summary) (1.13 KB, patch)
2012-07-23 09:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 8395: Fix sort order in parcel.tt (summary) (1.46 KB, patch)
2012-07-23 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8395: Fix sort order in parcel.tt (summary) (1.58 KB, patch)
2012-07-25 19:35 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-07-09 16:30:30 UTC
Created attachment 10722 [details]
not sorted

See the attached image - when I click on the 'Summary' heading to sort things, they are in no order that I can figure out.  They should be in alpha order by title since that's the first bit of data in that field.
Comment 1 Jonathan Druart 2012-07-23 09:45:46 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-07-23 09:50:47 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2012-07-25 19:35:46 UTC
Created attachment 11138 [details] [review]
[SIGNED-OFF] Bug 8395: Fix sort order in parcel.tt (summary)

Signed-off-by: Marc Veron <veron@veron.ch>

Patch behaves as expected.
Comment 4 Mason James 2012-08-10 05:14:46 UTC
(In reply to comment #3)
> Created attachment 11138 [details] [review]
> [SIGNED-OFF] Bug 8395: Fix sort order in parcel.tt (summary)
> 
> Signed-off-by: Marc Veron <veron@veron.ch>
> 
> Patch behaves as expected.

trival patch, passing QA :)
Comment 5 Chris Cormack 2012-08-10 19:50:51 UTC
Patch does not apply on 3.8.x, if you want this in the 3.8.x branch,please submit a new patch based on it.
Comment 6 Paul Poulain 2012-08-29 13:33:38 UTC
Patch pushed to master
Comment 7 Chris Cormack 2012-08-29 21:08:22 UTC
Still need a patch for 3.8.x if this is needed for that branch
Comment 8 Colin Campbell 2012-09-07 15:44:17 UTC
I dont think this fixes the problem. At a typical academic/public site receipting against a major supplier some 500+ orders may appear. But the sorting by summary only affects the page of results displayed move forward and sort order reverts to basket order. As there may be multiple orders for one title locating all of them is difficult.
Comment 9 Jonathan Druart 2012-09-10 08:05:49 UTC
(In reply to comment #8)
> I dont think this fixes the problem. At a typical academic/public site
> receipting against a major supplier some 500+ orders may appear. But the
> sorting by summary only affects the page of results displayed move forward
> and sort order reverts to basket order. As there may be multiple orders for
> one title locating all of them is difficult.

Hi Colin,
Yes you are right. But this patch fixes a problem and allows to have the same behaviour (without regression) as we have before datatable.
Maybe we want to hide pagination on this table to be more consistent.
To have a sort on all results, we have to implement datatable with a server-side processing.
Comment 10 Chris Cormack 2013-04-20 22:17:21 UTC
Released in 3.10.0