Currently if you have an expired subscription you see on the subscription detail page a message saying "Subscription will expire [ date in the past ]." It would be more accurate and helpful to say "Subscription expired on [ expiration date ]."
Created attachment 11871 [details] [review]
Bug 8694 - Show accurate subscription renewal warning for expired subscriptions
This patch adds a check of the subscription end date when
displaying the "about to expire" message, substituting a
"already expired" warning in its place if the expiration
date is in the past.
To test, view a subscription which is about to expire
and a subscription which has already expired. You should
see two different versions of the message.
Created attachment 11907 [details]
Subscription that caused an error.
Attempting to save this subscription after applying the patch caused the following error:
Usage: Date::Calc::Delta_Days(year1, month1, day1, year2, month2, day2) at /home/koha/kohaclone/serials/subscription-detail.pl line 103.