Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files
Summary: OPACBaseURL still called as OPACBaseurl in many files
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-12 22:45 UTC by David Cook
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files (7.83 KB, patch)
2012-09-24 20:06 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files (7.88 KB, patch)
2012-09-28 13:09 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2012-09-12 22:45:38 UTC
OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt

It also shows up in many Poodle files. 

Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but it's still probably a good idea to have it spelled correctly.
Comment 1 David Cook 2012-09-12 23:05:16 UTC
(In reply to comment #0)
> OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt
> 
> It also shows up in many Poodle files. 
> 
> Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but
> it's still probably a good idea to have it spelled correctly.

Pootle :P
Comment 2 Owen Leonard 2012-09-24 20:06:19 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2012-09-28 13:09:02 UTC
Created attachment 12579 [details] [review]
[SIGNED-OFF] Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files

This patch fixes incorrect capitalization of the OPACBaseURL
variable in three templates. The fix can be confirmed in
opac-results.tt by inspecting the link attached to the RSS
icon on the OPAC's search results screen. The same fix is included
in opac-opensearch.tt and search/results.tt but I'm not sure
how you confirm that this change fixes anything, if it does.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall 2012-09-28 13:12:34 UTC
OPACBaseURL is set by get_template_and_user so having a script in the opac directory set it as well is superfluous, but not harmful.
Comment 5 Paul Poulain 2012-10-12 14:34:11 UTC
QA comment: tiny patch, just change capitalization
Comment 6 Paul Poulain 2012-10-12 14:34:28 UTC
Patch pushed to master
Comment 7 Chris Cormack 2012-10-14 07:25:34 UTC
Patch doesn't apply on 3.8.x, please rebase and submit if it is needed.
Comment 8 David Cook 2012-10-15 19:21:25 UTC
(In reply to comment #7)
> Patch doesn't apply on 3.8.x, please rebase and submit if it is needed.

It seems to me that the patch is getting hung up on opac-tmpl\prog\en\modules\search\results.tt, which doesn't exist in 3.8.x as it is a file specific to BibLibre's work with Solr in master. 

Wouldn't this be a case where the commit needs to be cherrypicked to 3.8.x from master and the bit about search\results.tt removed while the rest of the patch remains relevant?
Comment 9 Chris Cormack 2012-10-15 20:47:27 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Patch doesn't apply on 3.8.x, please rebase and submit if it is needed.
> 
> It seems to me that the patch is getting hung up on
> opac-tmpl\prog\en\modules\search\results.tt, which doesn't exist in 3.8.x as
> it is a file specific to BibLibre's work with Solr in master. 
> 
> Wouldn't this be a case where the commit needs to be cherrypicked to 3.8.x
> from master and the bit about search\results.tt removed while the rest of
> the patch remains relevant?

Exactly, but what I want is the patch author to do that, so and attach a 3.8.x patch, so I don't muck it up :)
Comment 10 Chris Cormack 2013-04-21 00:45:56 UTC
Still waiting on a 3.8.x patch for this
Comment 11 David Cook 2014-01-17 06:10:06 UTC
(In reply to Kyle M Hall from comment #4)
> OPACBaseURL is set by get_template_and_user so having a script in the opac
> directory set it as well is superfluous, but not harmful.

At the time, I don't think I 100% understood what you meant by this, but I do now.

I suppose it's not harmful so long as it doesn't tamper with the https detection happening in Auth.pm. 

That said, at the moment, I think the OPACBaseURL set by get_template_and_user is using an environmental "SERVER_NAME" variable (which appears to be the domain name that a user puts into their browser, rather than the ServerName in the Apache conf), rather than the OPACBaseURL system preference. While this might not be an issue in many cases, it appears to cause issues for Koha instances sitting behind proxy servers...


I'm opening bug 11575 to deal with that...