Bug 8878 - koha-shell: a command to make using koha commands easier
Summary: koha-shell: a command to make using koha commands easier
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Robin Sheat
QA Contact: Marcel de Rooy
URL:
Keywords:
: 7667 (view as bug list)
Depends on:
Blocks: 9784
  Show dependency treegraph
 
Reported: 2012-10-05 00:55 UTC by Robin Sheat
Modified: 2015-06-04 23:23 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8878 - a command to provide a shell with the koha environment (9.11 KB, patch)
2012-10-05 03:06 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 8878 - a command to provide a shell with the koha environment (9.23 KB, patch)
2012-11-19 01:01 UTC, Mason James
Details | Diff | Splinter Review
Patch (9.27 KB, patch)
2012-12-20 08:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2012-10-05 00:55:09 UTC
Need a command that drops you into a shell with your environment set up for interacting with koha, by setting PERL5LIB and KOHA_CONF appropriately, etc.
Comment 1 Robin Sheat 2012-10-05 03:06:02 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-10-05 12:57:01 UTC
No matter what switches I use, I always get the following "Error: An instance name must be supplied."
Comment 3 Katrin Fischer 2012-10-05 13:59:43 UTC
Kyle, did you use this with the koha-common packages and instances created by them?
Comment 4 Robin Sheat 2012-10-05 20:01:55 UTC
Did you supply an instance name?
Comment 5 Robin Sheat 2012-10-05 20:03:36 UTC
(and as Katrin mentions, it's supposed to be used in the context of the packages.)
Comment 6 Kyle M Hall 2012-10-09 13:22:37 UTC
I think you are correct in that I was testing it incorrectly. Switching back to 'Needs Signoff'.
Comment 7 Mason James 2012-11-19 01:01:06 UTC Comment hidden (obsolete)
Comment 8 Mason James 2012-11-19 01:02:29 UTC
(In reply to comment #7)
> Created attachment 13506 [details] [review]
> Bug 8878 - a command to provide a shell with the koha environment
> Signed-off-by: Mason James <mtj@kohaaloha.com>

works well, signing off patch
Comment 9 Marcel de Rooy 2012-12-20 08:39:20 UTC
QA Comment:
This patch was first on the list; so I had to pick it :) Did some limited testing of koha-shell outside packaging env (needed some tweaking).
Code looks good. Well documented.
As a non-packaging user, some things may not be obvious directly: such as with instance X comes user X-koha. Not a problem.
This patch will not break anything; it just adds the koha-shell 'command'.

Small note: The perl script has a copyright statement not worded exactly as other perl scripts in Koha like (This file is part of Koha, etc.)

Passed QA
Comment 10 Marcel de Rooy 2012-12-20 08:41:23 UTC
Created attachment 14209 [details] [review]
Patch
Comment 11 Magnus Enger 2012-12-20 09:31:36 UTC
A short description of the new script could/should also be added to debian/docs/koha-common.xml.
Comment 12 Jared Camins-Esakov 2012-12-20 13:02:31 UTC
This patch has been pushed to master.
Comment 13 Chris Cormack 2012-12-21 19:23:44 UTC
Pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8
Comment 14 Martin Renvoize 2014-02-19 12:15:58 UTC
Whenever using the koha-shell command I am met with the following error messages:

bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell

Is this something specific to my setup, or is it a general bug/oddity?
Comment 15 Martin Renvoize 2014-02-19 13:07:13 UTC
Looks like Galen has reported the bug now: bug 11775
Comment 16 MJ Ray (software.coop) 2014-07-09 12:16:48 UTC
*** Bug 7667 has been marked as a duplicate of this bug. ***