Bug 8956 - Split serials enumeration data into separate fields
Summary: Split serials enumeration data into separate fields
Status: RESOLVED DUPLICATE of bug 12375
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 17292
  Show dependency treegraph
 
Reported: 2012-10-23 13:49 UTC by Kyle M Hall
Modified: 2016-09-12 15:13 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB (3.72 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials (6.67 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl (3.94 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes (8.61 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. (8.23 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl (23.67 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. (8.66 KB, patch)
2012-10-25 14:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB (3.59 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials (6.52 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl (3.95 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes (8.57 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. (8.18 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl (23.38 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. (8.62 KB, patch)
2013-03-06 18:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB (3.63 KB, patch)
2013-03-19 09:53 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials (6.52 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl (3.95 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes (8.57 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. (8.18 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl (24.24 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. (7.97 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again (3.19 KB, patch)
2013-03-19 09:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB (3.63 KB, patch)
2013-05-31 16:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials (6.52 KB, patch)
2013-05-31 16:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl (3.94 KB, patch)
2013-05-31 16:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes (8.57 KB, patch)
2013-05-31 16:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. (8.18 KB, patch)
2013-05-31 16:24 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl (23.99 KB, patch)
2013-05-31 16:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. (7.97 KB, patch)
2013-05-31 16:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again (3.19 KB, patch)
2013-05-31 16:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB (3.63 KB, patch)
2013-05-31 22:21 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials (6.59 KB, patch)
2013-05-31 22:21 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl (4.01 KB, patch)
2013-05-31 22:21 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes (8.63 KB, patch)
2013-05-31 22:21 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. (8.25 KB, patch)
2013-05-31 22:21 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl (24.05 KB, patch)
2013-05-31 22:22 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. (8.04 KB, patch)
2013-05-31 22:22 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again (3.26 KB, patch)
2013-05-31 22:22 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB (3.70 KB, patch)
2013-05-31 23:36 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials (6.59 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl (4.01 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes (8.63 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. (8.25 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl (24.05 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. (8.04 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again (3.26 KB, patch)
2013-05-31 23:37 UTC, Melia Meggs
Details | Diff | Splinter Review
Bug 8956 - Split serials enumeration data into separate fields - Part 9 - Remove print from database update (1.03 KB, patch)
2013-06-05 15:04 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-10-23 13:49:02 UTC
Work to be done

1)   Add an option 'published_end_date' to the serials table. It will only be
used to represent the last issue date in a bound volume.
2)   Data clean up:  Extract the published dates from the existing enumeration
field. Populate serials.publisheddate and serials.published_end_date with this
data.
3)   Strip the publishing dates from their enumeration fields (probably by
simply deleting matched parentheses and everything in between them).
4)   In order to break the “Numbered” field into three columns, add X, Y and Z
columns to serials, as well as X, Y and Z descriptions columns to the
subscription table.
5)   Port existing data into these columns.  Once all the enumeration fields
are of the correct format, e.g., Vol. X No. Y, we can use everything preceding
{X} as X_Description, and everything preceding {Y} until } as Y_Description. 
Another way to look at this is if we split on {?}, we will have all the label
fields in order of use. Once we have the label fields, we can parse those out
of the enumeration string, and we will have the set of values they represent.
6)   Add a calendar widget for published on and expected on (serials-edit.pl).
This will require librarians to enter new dates in the accepted format.
Comment 1 Kyle M Hall 2012-10-25 14:46:01 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-10-25 14:46:10 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2012-10-25 14:46:18 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2012-10-25 14:46:25 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2012-10-25 14:46:37 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2012-10-25 14:46:47 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2012-10-25 14:46:54 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall 2012-10-25 14:56:13 UTC
TEST PLAN

Part 1:
1) Apply patch and run updatedatabase.pl
2) Verify the new fields have been created. The new serialseq fields should be the correct data, assuming the serials are following Koha standards. NOTE: It is not necessary for this data to be absolutely correct. This data is really for statistical purposes at the moment, but do pave the way for future serials improvements.

Part 2:
1) Apply the patch
2) Create a new subscription, and add serials to it. The new x y and z fields should be populated with the same data the replaces {X} {Y} and {Z} in the enumeration field.

Part 3:
1) Apply the patch
2) Add/update a serial, and choose dates via the datepicker.
3) Verify the data is saved correctly in the database.

Part 4:
1) Apply the patch. Add/update a serial, and choose a published end date.
2) Verify the date was stored in the database correctly ( serials.published_end_date )
NOTE: The purpose of this feature is to better handle the dates of bound volumes of serials. Right now, we specify the first published date, but not the published date of the last issue in a bound volume.

Part 5-7:
1) Apply the patches
2) Create a new serial. You can now see that instead of having the labels described in the enumeration field, we have three new replacement variables {XL}, {YL} and {ZL}.
3) Generate a new serial and verify the placeholders are replaced with the correct labels.
Note: This feature will not affect existing serials, so it should be upgrade safe.
Comment 9 Kyle M Hall 2012-10-25 15:00:47 UTC
I think this bug needs some exposition. We have libraries that are finding it difficult to generate reports for serials for the following reasons:
1) Parsing serialseq to get issue/vol/no/whatever data is difficult
2) Librarians put incorrectly formatted dates in the date fields
3) There is no proper way to store the published date of the last issue of a bound volume.

Parts 1 through 4 are the only critical patches to resolve these issue. Parts 5-7 are just something I thought would be a nice way to advance the serials module. In the future, it may be possible to stop using serialseq and use the new fields in serial and subscription to display that data.
Comment 10 Kyle M Hall 2013-03-06 18:45:06 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall 2013-03-06 18:45:16 UTC Comment hidden (obsolete)
Comment 12 Kyle M Hall 2013-03-06 18:45:23 UTC Comment hidden (obsolete)
Comment 13 Kyle M Hall 2013-03-06 18:45:28 UTC Comment hidden (obsolete)
Comment 14 Kyle M Hall 2013-03-06 18:45:34 UTC Comment hidden (obsolete)
Comment 15 Kyle M Hall 2013-03-06 18:45:40 UTC Comment hidden (obsolete)
Comment 16 Kyle M Hall 2013-03-06 18:45:52 UTC Comment hidden (obsolete)
Comment 17 Alex Arnaud 2013-03-19 08:29:01 UTC
First patch does not apply.
So, don't try to apply others.
Comment 18 Kyle M Hall 2013-03-19 09:53:54 UTC Comment hidden (obsolete)
Comment 19 Kyle M Hall 2013-03-19 09:54:07 UTC Comment hidden (obsolete)
Comment 20 Kyle M Hall 2013-03-19 09:54:16 UTC Comment hidden (obsolete)
Comment 21 Kyle M Hall 2013-03-19 09:54:24 UTC Comment hidden (obsolete)
Comment 22 Kyle M Hall 2013-03-19 09:54:32 UTC Comment hidden (obsolete)
Comment 23 Kyle M Hall 2013-03-19 09:54:40 UTC Comment hidden (obsolete)
Comment 24 Kyle M Hall 2013-03-19 09:54:47 UTC Comment hidden (obsolete)
Comment 25 Kyle M Hall 2013-03-19 09:54:54 UTC Comment hidden (obsolete)
Comment 26 Alex Arnaud 2013-03-20 10:03:31 UTC
I have created a subscription with numbering pattern to "Volume, number" and set:
{X} Label: Year
{Y} Label: Number

I cre
Comment 27 Alex Arnaud 2013-03-20 10:11:13 UTC
I created a serial and description is ok: "Year 2013, Number 1".
But if i edit this subscription again, x and y label are reset to "Vol" and "Number". But serials are not affected. Adding a new one create a description like "Year 2013, Number 2".

Also, it could be better the Test prediction pattern use defined labels instead of "{XL} 2013, {YL} 1"
Comment 28 Kyle M Hall 2013-05-31 16:24:20 UTC Comment hidden (obsolete)
Comment 29 Kyle M Hall 2013-05-31 16:24:29 UTC Comment hidden (obsolete)
Comment 30 Kyle M Hall 2013-05-31 16:24:38 UTC Comment hidden (obsolete)
Comment 31 Kyle M Hall 2013-05-31 16:24:49 UTC Comment hidden (obsolete)
Comment 32 Kyle M Hall 2013-05-31 16:24:58 UTC Comment hidden (obsolete)
Comment 33 Kyle M Hall 2013-05-31 16:25:08 UTC Comment hidden (obsolete)
Comment 34 Kyle M Hall 2013-05-31 16:25:17 UTC Comment hidden (obsolete)
Comment 35 Kyle M Hall 2013-05-31 16:25:26 UTC Comment hidden (obsolete)
Comment 36 TTUHSC libraries 2013-05-31 19:02:10 UTC
Kyle, after review by our serials staff I now sign off on this dev.

Paul Landers
Texas Tech University Health Sciences Center
Library I.T.
Comment 37 Melia Meggs 2013-05-31 22:21:13 UTC Comment hidden (obsolete)
Comment 38 Melia Meggs 2013-05-31 22:21:25 UTC Comment hidden (obsolete)
Comment 39 Melia Meggs 2013-05-31 22:21:36 UTC Comment hidden (obsolete)
Comment 40 Melia Meggs 2013-05-31 22:21:46 UTC Comment hidden (obsolete)
Comment 41 Melia Meggs 2013-05-31 22:21:57 UTC Comment hidden (obsolete)
Comment 42 Melia Meggs 2013-05-31 22:22:09 UTC Comment hidden (obsolete)
Comment 43 Melia Meggs 2013-05-31 22:22:18 UTC Comment hidden (obsolete)
Comment 44 Melia Meggs 2013-05-31 22:22:27 UTC Comment hidden (obsolete)
Comment 45 Melia Meggs 2013-05-31 23:36:58 UTC
Created attachment 18576 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 46 Melia Meggs 2013-05-31 23:37:08 UTC
Created attachment 18577 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 47 Melia Meggs 2013-05-31 23:37:15 UTC
Created attachment 18578 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 48 Melia Meggs 2013-05-31 23:37:22 UTC
Created attachment 18579 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 49 Melia Meggs 2013-05-31 23:37:31 UTC
Created attachment 18580 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor.

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 50 Melia Meggs 2013-05-31 23:37:39 UTC
Created attachment 18581 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 51 Melia Meggs 2013-05-31 23:37:47 UTC
Created attachment 18582 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels.

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 52 Melia Meggs 2013-05-31 23:37:55 UTC
Created attachment 18583 [details] [review]
[Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again

Signed-off-by: Paul Landers <paul.landers@ttuhsc.edu>
Comment 53 Melia Meggs 2013-05-31 23:38:42 UTC
Helping Paul add his sign off.
Comment 54 Marcel de Rooy 2013-06-05 14:45:23 UTC
Just some advance remarks:

In total this is a larger patch. It could be advantageous if Paul as the one signing off, could further elaborate on what he exactly tested. Did you test various numbering patterns, how much data was converted in the upgrade, etc. etc. In this way we can build up some more confidence in this development.

I just had a quick look:

The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be very informative?
The label X, etc with Appears in numbering formula as {XL} do not seem very easy to understand on Edit subscription? [This already held for numbering patterns, but life is not simpler now..]
Funny date in next issue publication date: 02/00/0 Do not know what happened here, but could be an existing problem..

Thanks.
Comment 55 Kyle M Hall 2013-06-05 15:04:45 UTC
Created attachment 18679 [details] [review]
Bug 8956 - Split serials enumeration data into separate fields - Part 9 - Remove print from database update
Comment 56 Kyle M Hall 2013-06-05 15:05:47 UTC
He followed the test plan in part 8.

(In reply to comment #54)
> Just some advance remarks:
> 
> In total this is a larger patch. It could be advantageous if Paul as the one
> signing off, could further elaborate on what he exactly tested. Did you test
> various numbering patterns, how much data was converted in the upgrade, etc.
> etc. In this way we can build up some more confidence in this development.
> 
> I just had a quick look:
> 
> The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be
> very informative?
> The label X, etc with Appears in numbering formula as {XL} do not seem very
> easy to understand on Edit subscription? [This already held for numbering
> patterns, but life is not simpler now..]
> Funny date in next issue publication date: 02/00/0 Do not know what happened
> here, but could be an existing problem..
> 
> Thanks.
Comment 57 Kyle M Hall 2013-06-05 15:06:33 UTC
The test plan in comment 8 that is ; )

I've also attached a qa followup to remove that print line from the db update.


(In reply to comment #56)
> He followed the test plan in part 8.
> 
> (In reply to comment #54)
> > Just some advance remarks:
> > 
> > In total this is a larger patch. It could be advantageous if Paul as the one
> > signing off, could further elaborate on what he exactly tested. Did you test
> > various numbering patterns, how much data was converted in the upgrade, etc.
> > etc. In this way we can build up some more confidence in this development.
> > 
> > I just had a quick look:
> > 
> > The upgrade reports lines like : NUMBERING METHOD: '{X}' Does not seem to be
> > very informative?
> > The label X, etc with Appears in numbering formula as {XL} do not seem very
> > easy to understand on Edit subscription? [This already held for numbering
> > patterns, but life is not simpler now..]
> > Funny date in next issue publication date: 02/00/0 Do not know what happened
> > here, but could be an existing problem..
> > 
> > Thanks.
Comment 58 Melia Meggs 2013-06-13 21:49:39 UTC
For Paul's testing, he created 2 new serials using an X Y Z numbering pattern (I believe he tried Volume, Number, Issue, as well as Volume, Number, Year, if I remember correctly).  He verified that the new fields were showing up, and he tried using the datepicker a few times.  He also edited an existing serial to make sure the new fields looked ok.

(I was watching with screen sharing while he went through the test plan, and then I helped him with the Git signoff.)
Comment 59 Katrin Fischer 2013-07-07 10:57:38 UTC
I think this change might be in conflict with the big serials pattern patch that has reached 'Passed QA' already (bug 7688).
Comment 60 Jonathan Druart 2013-09-02 12:35:48 UTC
(In reply to Katrin Fischer from comment #59)
> I think this change might be in conflict with the big serials pattern patch
> that has reached 'Passed QA' already (bug 7688).

I already talk about this possible problem with Julian (author of the feature 7688). On a functional point of view the 2 features are not in conflict but, inevitably, the patches will not apply cleanly.
Comment 61 Kyle M Hall 2013-09-04 12:46:40 UTC
(In reply to Jonathan Druart from comment #60)
> (In reply to Katrin Fischer from comment #59)
> > I think this change might be in conflict with the big serials pattern patch
> > that has reached 'Passed QA' already (bug 7688).
> 
> I already talk about this possible problem with Julian (author of the
> feature 7688). On a functional point of view the 2 features are not in
> conflict but, inevitably, the patches will not apply cleanly.

I suppose the big question is: which of the two will be easier to rebase over top the other.
Comment 62 Katrin Fischer 2013-09-29 18:25:51 UTC
Starting with a code review based on squashed patches:

1) Bug number missing from database update

2) In subscription-add.pl there is a typo, not sure the consequences:
   -    $templte->param(letterloop => $letterloop);
   +    $templte->param( letterloop => $letterloop );

3) I'd really like to have more information about the use of the 
   published_end_date and bound volumes - this seems to be a separate 
   feature. The test plan says:

>Part 4:
>1) Apply the patch. Add/update a serial, and choose a published end date.
>2) Verify the date was stored in the database correctly ( >serials.published_end_date )
>NOTE: The purpose of this feature is to better handle the dates of bound >volumes of serials. Right now, we specify the first published date, but not the >published date of the last issue in a bound volume.

There is currently no real workflow for adding bound volumes - what are you referring to here? What steps lead to a bound volume for this library?

--
I am a bit worried about the amount of testing this has seen - was an existing database converted with this patch? What were the results? Were other more unusual subscription patterns tested as well?
Comment 63 Katrin Fischer 2013-10-04 21:25:43 UTC
Hi Kyle, 

failing to get your attention and answers to my questions :)
Comment 64 Kyle M Hall 2014-06-05 16:32:41 UTC

*** This bug has been marked as a duplicate of bug 12375 ***