Bug 8983 - Typo error in UNIMARCslim2OPACResults.xsl
Summary: Typo error in UNIMARCslim2OPACResults.xsl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 10:19 UTC by Fridolin Somers
Modified: 2013-12-05 20:01 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.00 KB, patch)
2012-10-30 10:22 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8983: Typo error in UNIMARCslim2OPACResults.xsl (1.10 KB, patch)
2012-11-09 15:29 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-10-30 10:19:24 UTC
In UNIMARCslim2OPACResults.xsl, type in the "on order" items :
<xsl:if test="count(key('item-by-status', 'On Orangemanr'))>0">
Comment 1 Fridolin Somers 2012-10-30 10:22:54 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2012-10-30 10:54:04 UTC
Hi Fridolyn,

I think you are only shifting the problem with this patch. The real fix is to make the string appear in the po files to get it properly translated. Introducing a French string in an English file is not the right solution.

Also, I think there is a way to make this work, as the status appears correctly in our catalog for the MARC21 XSLT results. (I just checked in one of our libraries, I can find you a link if you want).
Comment 3 Katrin Fischer 2012-10-30 13:09:57 UTC
Argh. I totally misread your patch, I am quite sorry. Very sorry.
Comment 4 Jared Camins-Esakov 2012-11-01 19:55:13 UTC
String changes. Will hold for post-3.10.0.
Comment 5 Kyle M Hall 2012-11-09 15:29:18 UTC
Created attachment 13352 [details] [review]
[SIGNED-OFF] Bug 8983: Typo error in UNIMARCslim2OPACResults.xsl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Jonathan Druart 2012-11-20 15:49:40 UTC
QA Comment:

Fix typo in UNIMARCslim2OPACResults.xsl

Marked as Passed QA.
Comment 7 Jared Camins-Esakov 2012-11-23 18:07:17 UTC
This patch has been pushed to master.
Comment 8 Chris Cormack 2012-11-26 01:13:49 UTC
Pushed to 3.10.x will be in 3.10.1
Comment 9 Chris Cormack 2012-11-26 07:39:23 UTC
Pushed to 3.8.x will be in 3.8.8
Comment 10 Liz Rea 2012-11-28 22:43:02 UTC
Pushed to 3.6.x will be in 3.6.11.