Bug 7986 introduced an issues. Items are not exported at least when you use the script tools/export.pl from a command line and you want to export biblios with items. This patch could have a higher severity level (blocker).
Created attachment 13366 [details] [review] Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline).
Created attachment 13369 [details] [review] Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 13389 [details] [review] Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference"
Created attachment 13413 [details] [review] Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" Signed-off-by: Mason James <mtj@kohaaloha.com>
I increase the severity of this patch. Without this patch, the export tools (via ui) does not work too (items are not added to the export file). To test : tools/export.pl and export with and without the items. In the current master, you will get the same file (without items).
QA comment: * 2 lines patch, fixing a bug * nothing changed in string passed QA
This patch has been pushed to master.
Patch pushed to branch 3.10.x
Released in 3.10.0
Created attachment 21378 [details] [review] [3.8.x] FIX wrong test on an arrayref instead of an array Backport of patch 1 to 3.8.18, which should apply nicely to 3.8.x.
Created attachment 21379 [details] [review] [3.8.x] Followup FIX perl v.10 raises an error if itemnumbers if undefined Backport of patch 2 to 3.8.18, which should apply nicely to 3.8.x
This is already resolved in 3.10.x and higher, but the 3.8.x patches are back ports in need of testing, QA'ing, and getting in 3.8.x. :)
Just apply the 3.8.x patches to 3.8.x for testing. :)
Patch applied cleanly, go forth and signoff
Created attachment 21568 [details] [review] Bug 9046: FIX wrong test on an arrayref instead of an array EmbedItemsInMarcBiblio does not embed items when the itemnumbers param is given. That breaks the export tools (used from commandline). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 21569 [details] [review] Bug 9046: Followup FIX perl v.10 raises an error if itemnumbers if undefined If the itemnumbers parameter is undef, perl raises an error : "Can't use an undefined value as an ARRAY reference" Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed off the 3.8.x patches, probably can skip QA as they have been in master for a while, but up to the RMaint
passing QA, I agree with chris last comment: the current patch is for 3.8
ping Kyle, it seems the next action if for you :)
Pushed to 3.8.x! Will be in v3.08.24 Kyle