When displaying the Saved reports, since 3.10 the number of columns is higher but the datasorter parameters have not been changed accordingly. It's thus impossible to sort on the author or the creation date, for example.
Created attachment 13800 [details] [review] proposed patch TEST PLAN : 1) Check sortable columns before applying : some useful columns are not sortable, while the last columns are sortable (but don't need to be). 2) Once the patch is applied, the "non sortable" columns are the correct ones.
Created attachment 13801 [details] [review] [Signed off] Bug 9182: corrects sortable columns on Saved reports Signed-off-by: Melia Meggs <melia@bywatersolutions.com>
Before applying this patch, I tested on master and found that the following columns in reports are sortable: Report ID, Report Name, Type, Area, Group, Subgroup, Saved SQL, and the two furthest columns to the right, which are unlabeled. The following columns are NOT sortable: Notes, Author, Creation Date, Public, Saved Results. After applying the patch, I found that the following columns are now sortable: Report ID, Report Name, Type, Area, Group, Subgroup, Notes, Author, Creation Date. The following columns are now NOT sortable: Saved SQL, and the two further columns to the right which are unlabeled. This makes sense, and the column sorting appears to work correctly. I'm signing off!
Created attachment 13815 [details] screenshot It's still a little bit off for me. The 'Public' column is not sortable, but the last column 'Delete' is. Adrien or Melia,could you take another look please?
Oh yeah - good catch, Katrin. I left out the Public column in my note. Public is not sortable for me either. However, Delete is also not sortable. I guess it's back to you now, Adrien, to figure out how to make the Public column sortable as well.
Created attachment 14422 [details] [review] proposed patch #2 In this new patch, the public column should be sortable!
Created attachment 14424 [details] [review] [SIGNED-OFF] Bug 9182: fix on sortable columns on Saved reports When displaying the Saved reports, since 3.10 the number of columns is higher but the datasorter parameters have not been changed accordingly. It's thus impossible to sort on the author or the creation date, for example. TEST PLAN : 1) Check sortable columns before applying : some useful columns are not sortable, while the last columns are sortable (but don't need to be). 2) Once the patch is applied, the "non sortable" columns are the correct ones. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 14555 [details] [review] [SIGNED-OFF] Bug 9182: fix on sortable columns on Saved reports When displaying the Saved reports, since 3.10 the number of columns is higher but the datasorter parameters have not been changed accordingly. It's thus impossible to sort on the author or the creation date, for example. TEST PLAN : 1) Check sortable columns before applying : some useful columns are not sortable, while the last columns are sortable (but don't need to be). 2) Once the patch is applied, the "non sortable" columns are the correct ones. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Colums for saved reports are all sortable correctly now. All tests and qa script pass.
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x, will be in 3.10.2 and 3.8.9