Bug 9182 - Saved reports list : wrong sortable columns
Summary: Saved reports list : wrong sortable columns
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Adrien SAURAT
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 9349
  Show dependency treegraph
 
Reported: 2012-11-30 15:57 UTC by Adrien SAURAT
Modified: 2014-05-26 21:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.13 KB, patch)
2012-11-30 16:02 UTC, Adrien SAURAT
Details | Diff | Splinter Review
[Signed off] Bug 9182: corrects sortable columns on Saved reports (1.20 KB, patch)
2012-11-30 19:49 UTC, Melia Meggs
Details | Diff | Splinter Review
screenshot (16.82 KB, image/png)
2012-12-01 23:20 UTC, Katrin Fischer
Details
proposed patch #2 (1.14 KB, patch)
2013-01-04 16:10 UTC, Adrien SAURAT
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9182: fix on sortable columns on Saved reports (1.69 KB, patch)
2013-01-04 16:46 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9182: fix on sortable columns on Saved reports (1.79 KB, patch)
2013-01-14 07:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2012-11-30 15:57:12 UTC
When displaying the Saved reports, since 3.10 the number of columns is higher but the datasorter parameters have not been changed accordingly.
It's thus impossible to sort on the author or the creation date, for example.
Comment 1 Adrien SAURAT 2012-11-30 16:02:28 UTC Comment hidden (obsolete)
Comment 2 Melia Meggs 2012-11-30 19:49:20 UTC Comment hidden (obsolete)
Comment 3 Melia Meggs 2012-11-30 19:49:49 UTC
Before applying this patch, I tested on master and found that the following columns in reports are sortable:  Report ID, Report Name, Type, Area, Group, Subgroup, Saved SQL, and the two furthest columns to the right, which are unlabeled.  The following columns are NOT sortable:  Notes, Author, Creation Date, Public, Saved Results.

After applying the patch, I found that the following columns are now sortable:  Report ID, Report Name, Type, Area, Group, Subgroup, Notes, Author, Creation Date.  The following columns are now NOT sortable:  Saved SQL, and the two further columns to the right which are unlabeled.

This makes sense, and the column sorting appears to work correctly.  I'm signing off!
Comment 4 Katrin Fischer 2012-12-01 23:20:59 UTC
Created attachment 13815 [details]
screenshot

It's still a little bit off for me. The 'Public' column is not sortable, but the last column 'Delete' is. Adrien or Melia,could you take another look please?
Comment 5 Melia Meggs 2012-12-03 17:03:15 UTC
Oh yeah - good catch, Katrin.  I left out the Public column in my note.  Public is not sortable for me either.  However, Delete is also not sortable.  I guess it's back to you now, Adrien, to figure out how to make the Public column sortable as well.
Comment 6 Adrien SAURAT 2013-01-04 16:10:03 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2013-01-04 16:46:23 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2013-01-14 07:17:36 UTC
Created attachment 14555 [details] [review]
[SIGNED-OFF] Bug 9182: fix on sortable columns on Saved reports

When displaying the Saved reports, since 3.10 the number of columns is
higher but the datasorter parameters have not been changed accordingly.
It's thus impossible to sort on the author or the creation date, for
example.

TEST PLAN :
1) Check sortable columns before applying : some useful columns are not
sortable, while the last columns are sortable (but don't need to be).

2) Once the patch is applied, the "non sortable" columns are the correct
ones.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Colums for saved reports are all sortable correctly now.
All tests and qa script pass.
Comment 9 Jared Camins-Esakov 2013-01-15 04:23:32 UTC
This patch has been pushed to master.
Comment 10 Chris Cormack 2013-01-15 05:07:52 UTC
Pushed to 3.10.x and 3.8.x, will be in 3.10.2 and 3.8.9