Bug 9225 - Subroutines should not be defined in acqui/parcel.pl
Summary: Subroutines should not be defined in acqui/parcel.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 12173
  Show dependency treegraph
 
Reported: 2012-12-06 13:51 UTC by Jared Camins-Esakov
Modified: 2015-12-03 22:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-12-06 13:51:02 UTC
We should not be declaring subroutines in .pl files. Unfortunately, there are three routines currently declared in acqui/parcel.pl. When run under Plack, this results in the following warnings in the log:
Subroutine get_value_with_gst_params redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 74.
Subroutine get_gste redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 93.
Subroutine get_gst redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 102.
Comment 1 Jonathan Druart 2015-03-05 11:28:11 UTC
These 3 subroutines have been removed by bug 13001.