This sort order had been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch.
Created attachment 14006 [details] [review] Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way.
Hi Kyle, just an easy fix, print "Upgrade to $DBversion done (Bug 9167: Update the virtualshelves.sortfield column with 'copyrightdate' if needed)\n"; You have the wrong message for the updatedatabase (it will need a rebase to apply also)
Created attachment 14887 [details] [review] Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way.
(In reply to comment #3) > 3) Test the sorting order for items with the preference set each way. This step is a little vague. In order to be thorough what places in Koha should we test? The most obvious choice, detail.pl, can't be properly tested because it has a JS-based tablesorter which overrides default sorting (something which should at the very least be addressed in a follow-up).
Applying: Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. Using index info to reconstruct a base tree... M C4/Items.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging C4/Items.pm Patch failed at 0001 Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 27295 [details] [review] Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way. NOTE: I only rebased to make it apply. I still think Owen's feedback in comment #4 still applys. Hence the move from 'Patch does not apply' to 'In Discussion'.
Created attachment 123705 [details] [review] Bug 9264 - Make getitems default sort to set by a preference instead of hard coded to homebranch. The sort order in GetItemsInfo has been switched from home branch to holding branch and then back again at different points in time. Some libraries liked it when it was by holding branch, rather than home branch. This patch makes the choice of sorting by home or holding branch a system preference. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Test the sorting order for items with the preference set each way. NOTE: I only rebased to make it apply. I still think Owen's feedback in comment #4 still applys. Hence the move from 'Patch does not apply' to 'In Discussion'.
(In reply to Owen Leonard from comment #4) > (In reply to comment #3) > > 3) Test the sorting order for items with the preference set each way. > > This step is a little vague. In order to be thorough what places in Koha > should we test? The most obvious choice, detail.pl, can't be properly tested > because it has a JS-based tablesorter which overrides default sorting > (something which should at the very least be addressed in a follow-up). I can't see that this has affect anywhere, most pages are loading a datatables so the sorting is overridden