Bug 9376 - Problem with dateexpiry display in moremember.tt
Summary: Problem with dateexpiry display in moremember.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P1 - high minor (vote)
Assignee: Vitor Fernandes
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 9406
  Show dependency treegraph
 
Reported: 2013-01-10 16:12 UTC by Vitor Fernandes
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9376: Problem with dateexpiry display in moremember.tt (1.56 KB, patch)
2013-01-10 16:31 UTC, Vitor Fernandes
Details | Diff | Splinter Review
Bug 9376: Problem with dateexpiry display in moremember.tt (1.78 KB, patch)
2013-01-16 17:13 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 9376: extend HTML fix to moremember-brief.tt (1.08 KB, patch)
2013-01-16 17:13 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 9376: Problem with dateexpiry display in moremember.tt (1.85 KB, patch)
2013-01-17 13:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9376: extend HTML fix to moremember-brief.tt (1.16 KB, patch)
2013-01-17 13:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Fernandes 2013-01-10 16:12:33 UTC
There is a problem that brokens the interface of moremmeber when displaying the date expiry caused by this line:

<strong class="reregistryinfo">[% dateexpiry %]</span>

It should be:

<span class="reregitryinfo">[% dateexpiry %]</span>

It happens in version 3.8.
In version 3.10, I don't know if the problem happens.
Comment 1 Vitor Fernandes 2013-01-10 16:31:41 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-01-16 17:08:03 UTC
Confirmed that this affect 3.10.x.  It doesn't affect master, but only because of how the patch for bug 6261 reworks the member toolbar to use member/setstatus.pl rather than members/moremember.pl to renew the patron.
Comment 3 Galen Charlton 2013-01-16 17:13:11 UTC Comment hidden (obsolete)
Comment 4 Galen Charlton 2013-01-16 17:13:15 UTC Comment hidden (obsolete)
Comment 5 Galen Charlton 2013-01-16 17:14:02 UTC
Note that I added a follow-up patch along with my signoff.
Comment 6 Jonathan Druart 2013-01-17 13:32:12 UTC
QA comment:

The patch fixes a malformed strong tag.

Marked as Passed QA.
Comment 7 Jonathan Druart 2013-01-17 13:32:43 UTC
Created attachment 14662 [details] [review]
Bug 9376: Problem with dateexpiry display in moremember.tt

There is a problem that brokens the interface of moremmeber when
displaying the date expiry when renewing a patron.
In the first comment I said that the line that causes the error
should be:

<span class="reregitryinfo">[% dateexpiry %]</span>

but the correct way should be:

<strong class="reregitryinfo">[% dateexpiry %]</strong>

This way the date expiry after renew a patron appears in bold.

Test plan:

- before applying the patch try to renew a patron and check
  that almost everything went bold
- apply the patch
- renew a patron and only the expiration date is bolder.
- Note that the bug doesn't manifest in master because
  the patch for bug 6261 causes the invalid HTML to never
  be reached; it *does* affect 3.10.x and earlier.

Sponsored-by: KEEP SOLUTIONS
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2013-01-17 13:32:52 UTC
Created attachment 14663 [details] [review]
Bug 9376: extend HTML fix to moremember-brief.tt

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Jared Camins-Esakov 2013-01-18 02:08:24 UTC
This patch has been pushed to master.
Comment 10 Chris Cormack 2013-01-24 02:24:56 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10