It is not clear to the visually impaired that the book has been successfully returned.
Created attachment 14584 [details] [review] Adds feedback when book is checked in successfully a possible future entrancement is to make the text invisible but still read by screen readers.
Created attachment 14585 [details] [review] Adds feedback when book is checked in successfully a possible future entrancement is to make the text invisible but still read by screen readers.
Created attachment 14586 [details] [review] Adds feedback when book is checked in successfully a possible future entrancement is to make the text invisible but still read by screen readers.
Created attachment 14587 [details] [review] Adds feedback when book is checked in successfully a possible future enhancement is to make the text invisible but still read by screen readers. Oops, sorry for the triple-post.
This is not valid XHTML: <p class="problem"><h5>The item was returned</h5></p> It also perpetuates a class that we need to get rid of (not that one would know by looking at the code). The "problem" class is obsolete. This is a message rather than a warning, so it belongs in a different kind of dialog: <div class="dialog message"> <h5>Item successfully checked in</h5> </div> The above markup is valid, uses the proper message box style, and uses the correct phrase "checked in" which is default in the main "en" translation. I would like to see some references posted on this bug about the best way to offer text to screen readers which is hidden for sighted users. I think current Koha users are accustomed to the idea that "no news is good news" when checking out. Adding a message for those users disrupts their work flow by requiring that they distinguish between messages with actionable information and messages without.
Is this still valid? Now, the row is highlighted when it is checked in and says 'Checked in'.
I don't think anything has changed since the bug was reported, so probably still valid in the eyes of the reporter. However, since there has been no comment from the original submitter I'm inclined to mark this as "WONTFIX."