Created attachment 14801 [details] [review] Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type"
Can you please clarify what "hide items from purchase suggestions forms" means?
I worded the title poorly. The idea is to limit the list of item types one can choose when making a purchase suggestion. Some libraries have some many item types that it would be overwhelming for a patron to choose the correct one from the list. The idea is to pare down the list to a more manageable size for the purpose of choosing an itemtype for a purchase suggestions.
Do we need to have the purchase suggestion form ask for the item type in the first place? Not all libraries use item types that double as material types -- for example, if your item types are 'NORMAL', 'SHORT', 'NO_LOAN', that's not going to be of much use to the patron. So here's my counter-proposal: since suggestions.itemtype is a varchar(30) anyway, why not give it text input widgets instead of a drop-down list of item types, and maybe relabel it to make it clear that the library is asking for the preferred format (e.g., print, ebook, video, etc.).
I think giving patrons the freedom to type in anything will make it more complicated and confusing for some patrons. We could just add a new authorised value category instead. (In reply to comment #4) > Do we need to have the purchase suggestion form ask for the item type in the > first place? Not all libraries use item types that double as material types > -- for example, if your item types are 'NORMAL', 'SHORT', 'NO_LOAN', that's > not going to be of much use to the patron. > > So here's my counter-proposal: since suggestions.itemtype is a varchar(30) > anyway, why not give it text input widgets instead of a drop-down list of > item types, and maybe relabel it to make it clear that the library is asking > for the preferred format (e.g., print, ebook, video, etc.).
I ve tested it on a sanbox, it did not work, here s the error message : Applying: Bug 9468 - Add ability to hide items from purchase suggestions forms Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Koha.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Failed to merge in the changes.
Created attachment 16647 [details] [review] Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type"
Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr>
Created attachment 16674 [details] [review] Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
QA Comment: 2 smalls remarks: 1/ FAIL C4/Koha.pm OK pod FAIL forbidden patterns forbidden pattern: tab char (line 201) forbidden pattern: tab char (line 199) forbidden pattern: tab char (line 200) forbidden pattern: tab char (line 193) forbidden pattern: tab char (line 194) I know there are a lot of tab around these lines... 2/ qq{} is badly used at 2 places. Prefer q{} if you don't need a variable interpolation. Marked as Failed QA.
Created attachment 19086 [details] [review] Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
Whitespace looks good now: koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 77a5e3e 'Bug 10439: fix bug preventing the lib') OK C4/Koha.pm OK pod OK forbidden patterns OK valid OK critic OK installer/data/mysql/updatedatabase.pl OK pod OK forbidden patterns OK valid OK critic Also change the qq{}'s to q{}'s as well.
QA Comment: 1/ The syspref is created for OPAC but affect the intranet too : the C4::Koha::GetSupportList routine is used in suggestion/suggestion.pl. 2/ For the moment, this routine is only used in suggestions page, but could be used for something else, don't you think? 3/ Moreover it seems this routine is buggy. It does not deal with the multivalued AdvancedSearchTypes values (maybe I'm wrong). 4/ If the pref is equal to "ccode", don't we want to hide them too? Marked as Failed QA.
Created attachment 21759 [details] [review] Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
Created attachment 21760 [details] [review] Bug 9468 - Add ability to hide itemtypes from purchase suggestions forms - QA Followup
> 1/ The syspref is created for OPAC but affect the intranet too : the > C4::Koha::GetSupportList routine is used in suggestion/suggestion.pl. Fixed! > 2/ For the moment, this routine is only used in suggestions page, but could > be used for something else, don't you think? > 3/ Moreover it seems this routine is buggy. It does not deal with the > multivalued AdvancedSearchTypes values (maybe I'm wrong). I don't really no, but that would be beyond the scope of this bug. > 4/ If the pref is equal to "ccode", don't we want to hide them too? This is also beyond the scope of this bug. I future patch could extend this to ccodes and locations too.
Created attachment 22714 [details] [review] Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 22715 [details] [review] Bug 9468 - Add ability to hide itemtypes from purchase suggestions forms - QA Followup Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comments: Referring to Jonathan's comments and Kyle's replies: This works as advertised within its current limited implementation. Could be extended in the future. The function affects opac only now. Code looks good to me. No complaints from qa tools. Passed QA
(In reply to Kyle M Hall from comment #5) > I think giving patrons the freedom to type in anything will make it more > complicated and confusing for some patrons. We could just add a new > authorised value category instead. I think that's a much better approach than maintaining a dependency on item types, AdvancedSearchTypes, and introducing a limited-purpose system preference.
Created attachment 27932 [details] [review] Bug 9468: [COUNTER-PATCH] make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 27933 [details] [review] Bug 9468: [COUNTER-PATCH] define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 27934 [details] [review] Bug 9468: [COUNTER-PATCH] use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 27935 [details] [review] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
I have attached a series of counter-patches.
Created attachment 37100 [details] [review] [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37101 [details] [review] [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37102 [details] [review] [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37103 [details] [review] [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Kyle M Hall from comment #29) > Created attachment 37103 [details] [review] [review] > [SIGNED-OFF] Bug 9468: [COUNTER-PATCH] sample SUGGEST_FORMAT values > To test > ------- > [1] Verify that the new SQL inserts added by this patch work. Yes, it works, but only for English, please add them for others. The change to the opac prog theme should be removed.
Created attachment 38097 [details] [review] Bug 9468 [QA Followup]
Created attachment 38163 [details] [review] Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove OPAC prog file
Created attachment 38164 [details] [review] Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38165 [details] [review] Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38166 [details] [review] Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 38167 [details] [review] Bug 9468 [QA Followup]
Created attachment 38168 [details] [review] Bug 9468: followup insert ignore
Comment on attachment 38164 [details] [review] Bug 9468: define new SUGGEST_FORMAT authorize value Review of attachment 38164 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +37,4 @@ > use C4::Context; > use C4::Installer; > use C4::Dates; > +use C4::Koha qw/GetSupportList/; I think this should be avoided. What will happen in future versions of Koha? The routine can change, or completely removed. We should not call routines/methods from the Koha code in this file.
Hi Kyle, can you please take a look at Jonathan's comment#38? +use C4::Koha qw/GetSupportList/; I am not sure about some of the changes being intentional? if ($displayby =~ /status/i) { - if ( grep { /^($criteriumvalue)$/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { - return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))); - } else { - return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue) || $criteriumvalue; + unless ( grep { /$criteriumvalue/ } qw(ASKED ACCEPTED REJECTED CHECKED ORDERED AVAILABLE) ) { + return GetAuthorisedValueByCode('SUGGEST_STATUS', $criteriumvalue ) || "Unknown"; } + return ($criteriumvalue eq 'ASKED'?"Pending":ucfirst(lc( $criteriumvalue))) if ($displayby =~/status/i); } return (GetBranchName($criteriumvalue)) if ($displayby =~/branchcode/); - return (GetSupportName($criteriumvalue)) if ($displayby =~/itemtype/); + return GetAuthorisedValueByCode('SUGGEST_FORMAT', $criteriumvalue) || "Unknown" if ($displayby =~/itemtype/); Also, "Pending" looks untranslatable there.
Created attachment 41822 [details] [review] Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove OPAC prog file
Created attachment 41823 [details] [review] Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 41824 [details] [review] Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 41825 [details] [review] Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 41826 [details] [review] Bug 9468 [QA Followup]
Created attachment 41827 [details] [review] Bug 9468: followup insert ignore
Created attachment 41828 [details] [review] Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl
Created attachment 41936 [details] [review] Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove OPAC prog file Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41937 [details] [review] Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41938 [details] [review] Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41939 [details] [review] Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41940 [details] [review] Bug 9468 [QA Followup] Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41941 [details] [review] Bug 9468: followup insert ignore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41942 [details] [review] Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 41943 [details] [review] Bug 9468: Fix syntax error in updatedb Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #54) > Created attachment 41943 [details] [review] [review] > Bug 9468: Fix syntax error in updatedb > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks for the followup Jonathan!
Can u please rebase ASAP?
Created attachment 44504 [details] [review] Bug 9468: make av-build-dropbox.inc available to OPAC This patch makes the av-build-dropbox.inc template include introduced by the latest patches for bug 766 available to the prog and Bootstrap themes in the OPAC. See later patches in this series for testing. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove OPAC prog file Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44505 [details] [review] Bug 9468: define new SUGGEST_FORMAT authorize value This patch defines a new authorized called SUGGEST_FORMAT for populating a list of patron-understandable formats for expressing how they would prefer suggested items to be purchased. For database upgrades, it populates it based on the value returned by the GetSupportList() routine. To test ------- [1] Run the database update. [2] Verify that there is a new authorised value called SUGGEST_FORMAT whose codes and descriptions correspond to the list of "item types" available on the patron suggestion form. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44506 [details] [review] Bug 9468: use new SUGGEST_FORMAT list This patch uses the new SUGGEST_FORMAT authorized value list for populating the list of suggestion item types/document types. It also improves the display by using the staff or OPAC description of the authorised value rather than the code. To test: [1] Enter a suggestion via the OPAC and select an item type (which I will call "desired format" for the rest of this test plan). [2] Verify that the saved suggestion displays the desired format description in both staff and OPAC. [3] Verify that organizing the list of suggestions by item type now works in the staff interface, rather than displaying "Unknown" in each tab header. [4] Verify that existing suggestions' desired formats are displayed correctly. [5] Verify that suggestions can have their desired format edited in the staff inteface. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44507 [details] [review] Bug 9468: sample SUGGEST_FORMAT values This patch adds some sample values for the SUGGEST_FORMAT authorized value list for new installations. To test ------- [1] Verify that the new SQL inserts added by this patch work. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44508 [details] [review] Bug 9468 [QA Followup] Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44509 [details] [review] Bug 9468: followup insert ignore Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 44510 [details] [review] Bug 9468 [QA Followup] - Remove GetSupportList dependency from updatadatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks Galen!