Bug 9510 - holiday exceptions are being ignored
Summary: holiday exceptions are being ignored
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Holidays (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-30 19:38 UTC by Melia Meggs
Modified: 2017-06-14 22:11 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Melia Meggs 2013-01-30 19:38:32 UTC
In 3.8, holiday exceptions are still being ignored.

What's happening is that when calculating the due date and skipping the days that the library is closed, the holiday exceptions are being ignored and skipped, even though the library is open.

To reproduce:
1) Set a repeating holiday.  Closed on Sats and Suns, for example.
2) Make an exception.  We're open this Saturday (but closed all of the other ones).
3) Set usedaysmode sys pref to skip all days the library is closed.
4) Set renewalbaseperiod to use the current date.
5) Check out some items.  See if due date is correctly calculated.
6) Renew some items.  See if due date is correctly calculated.
Comment 1 Katrin Fischer 2015-06-07 00:43:01 UTC
Could someoene retest this on a newer version? 3.8 is EOL.
Comment 2 Owen Leonard 2016-08-12 14:15:00 UTC
This appears to be fixed in master.