Bug 9566 - Only run analytics code if analytics are enabled
Summary: Only run analytics code if analytics are enabled
Status: RESOLVED DUPLICATE of bug 20702
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-07 16:50 UTC by Fridolin Somers
Modified: 2018-06-28 08:11 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (13.37 KB, patch)
2013-02-08 14:38 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-02-07 16:50:44 UTC
Bug 5528 introduced analytics records based on UNIMARC 461$0 and MARC21/NORMARC 773$0 and EasyAnalyticalRecords syspref.

Bug 7311 added a condition around code in additem.pl.
But this should be around all code related to analytics.
For libraries that does not use it, it is a gain of performance (the more important is to avoid search on hi index).
Comment 1 Fridolin Somers 2013-02-08 14:38:44 UTC
Created attachment 15165 [details] [review]
Proposed patch

See commit message.
Comment 2 Fridolin Somers 2013-02-08 14:40:14 UTC
Note that this problem can cause a really long response time (or even a timeout) for records with a lot of items like serials (because of search on hi index).
Comment 3 Chris Cormack 2013-02-17 07:43:58 UTC
Hmm, there are also normal analytics (not easy analytics), has this been checked with that? IE does it make sure not to break normal analytics?
Comment 4 Fridolin Somers 2013-03-07 16:33:13 UTC
(In reply to comment #3)
> Hmm, there are also normal analytics (not easy analytics), has this been
> checked with that? IE does it make sure not to break normal analytics?

Your right, I hope working on this with some people during hackfest.
Maybe addind a new syspref for all analitics code ; we have a library that uses UNIMARC 461$9 for another purpose.
Comment 5 Fridolin Somers 2018-06-28 08:10:50 UTC

*** This bug has been marked as a duplicate of bug 20702 ***
Comment 6 Fridolin Somers 2018-06-28 08:11:37 UTC
Solved at laaaaaaaaast, it will improve performance for records with a huge number of items. Thanks to all of you