Bug 9628 - Replace YUI buttons and menus on budgets administration pages with Bootstrap
Summary: Replace YUI buttons and menus on budgets administration pages with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/admin/aqbudgets.pl
Keywords:
Depends on:
Blocks: 22786
  Show dependency treegraph
 
Reported: 2013-02-15 17:01 UTC by Owen Leonard
Modified: 2019-04-26 17:31 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9628 - Replace YUI buttons and menus on budgets administration pages with Bootstrap (9.36 KB, patch)
2013-02-15 17:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9628 - Replace YUI buttons and menus on budgets administration pages with Bootstrap (9.43 KB, patch)
2013-02-15 17:55 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9628 - Replace YUI buttons and menus on budgets administration pages with Bootstrap (9.52 KB, patch)
2013-02-17 09:13 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-15 17:01:42 UTC
The toolbar include file used by budgets administration pages uses YUI to generate buttons and menus. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-15 17:05:29 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-15 17:55:54 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-02-17 09:13:41 UTC
Created attachment 15442 [details] [review]
[PASSED QA] Bug 9628 - Replace YUI buttons and menus on budgets administration pages with Bootstrap

This patch converts the toolbar include file used by budgets
administration pages to Bootstrap, replacing YUI button and menu code
with Bootstrap markup.

To test, create, view, and edit budgets. Buttons and menus should look
correct and work correctly. Functions include:

- New budget
- New fund
- Edit budget
- Duplicate budget
- Plan by (months, libraries, etc)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No error.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Jared Camins-Esakov 2013-02-18 13:24:52 UTC
This patch has been pushed to master.