On the page displaying orders in a basket, there is a a checkbox to show "all details". In fact, checking the box don't show all details, but only all prices. It could be useful for librarians to see statistical fields on this page. M. Saby Rennes 2 University
Created attachment 15609 [details] [review] Add a checkbox to display statistical fields in basket.tt This patch adds a checkbox in basket.tt to display the 2 statistical fields, and rename the "Show all details" checkbox to "Show all prices" To test : 1. open a basket, with some orders comprising some values in statistical fields 2. check/uncheck the 2 boxes "Show all prices" and "Show statistical fields" M. Saby
ok, I can see statistical fields when "Show statistical fields" is checked and all the prices when "Show all prices" is checked and both if the 2 boxes are checked
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Created attachment 16265 [details] [review] Bug 9692: Add a checkbox to display statistical fields in basket.tt This patch adds a checkbox in basket.tt to display the 2 statistical fields, and rename the "Show all details" checkbox to "Show all prices" To test : 1. open a basket, with some orders comprising some values in statistical fields 2. check/uncheck the 2 boxes "Show all prices" and "Show statistical fields" Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
QA comment: There are 3 issues: 1/ The columns does not hide if I unselect the new checkbox + [% IF ( listincgst ) %] + $("table .statistics").hide(); + [% ELSE %] + $("table .statistics").hide(); + [% END %] 2/ If these fields (sort1 and sort2) are linked to an authorized value, the description should be displayed, not the code. 3/ 2 withespaces: * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (43) The patch introduces a forbidden pattern: withespace character (35) Marked as Failed QA.
Thank you, I will look after that tomorrow. M. Saby
Still valid?
Created attachment 59202 [details] [review] Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt
I was able to fix the merge conflicts and points 1 and 3 in Jonathan's comment, but I didn't understand point 2. This is ready to test if point 2 isn't a block.
Hi Emma, CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt First patch does not apply, could you send the patch you rebased please?
Created attachment 59283 [details] [review] Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt
Second patch doesn't apply. Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9692-FOLLOWUP-Add-a-checkbox-to-display-statis-W5i0Tj.patch
I think the problem here is that we recenlty moved the Javascript to the bottom of the CC file. Resetting Asignee as Mathieu is no longer working on Koha. Still would be a good addition!