Bug 9730 - The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
Summary: The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a v...
Status: RESOLVED DUPLICATE of bug 6756
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Christophe Croullebois
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 15:12 UTC by Christophe Croullebois
Modified: 2015-07-14 10:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.79 KB, patch)
2013-02-28 16:10 UTC, Christophe Croullebois
Details | Diff | Splinter Review
bug 9370: test case for splitting LC call number (deleted)
2013-06-12 09:45 UTC, Chris Cormack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Croullebois 2013-02-28 15:12:07 UTC
it fails also if 'AnonymousPatron' = 0
With the patch in this case the borrowernumber becomes NULL
Comment 1 Christophe Croullebois 2013-02-28 16:10:16 UTC
Created attachment 15778 [details] [review]
proposed patch

To test :
Without patch leave 'AnonymousPatron' syspref blanck or with '0' value.
Try in Opac/my privacy to use 'Immediate deletion' with a patron who have a reading history.
The reading history is still present.
With patch, the same context, the reading history is deleted.
Thx for testing
Comment 2 Kyle M Hall 2013-03-01 16:03:44 UTC
I believe it would be more proper to disable the "my privacy' tab if AnonymousPatron is not a valid patron. This would be more in line with how OPACPrivacy requires opacreadinghistory and the tab does not show if opacreadinghistory is not set to "Allow".
Comment 3 Chris Cormack 2013-06-12 09:45:13 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2013-06-12 09:47:53 UTC
The content of attachment 18864 [details] has been deleted by
    Chris Cormack <chris@bigballofwax.co.nz>
without providing any reason.

The token used to delete this attachment was generated at 2013-06-12 21:47:50 NZST.
Comment 5 Christophe Croullebois 2013-07-18 09:26:56 UTC
I don't see comments about the failed QA status ?
An error ?
So I move in need ...
Comment 6 Christophe Croullebois 2013-07-18 09:33:55 UTC
oups sry Kyle, hum, you suggest to hide the tab in this case ...
Ok I'll do a new patch in this way
thx
Comment 7 Jonathan Druart 2015-07-14 10:25:44 UTC

*** This bug has been marked as a duplicate of bug 6756 ***