it fails also if 'AnonymousPatron' = 0 With the patch in this case the borrowernumber becomes NULL
Created attachment 15778 [details] [review] proposed patch To test : Without patch leave 'AnonymousPatron' syspref blanck or with '0' value. Try in Opac/my privacy to use 'Immediate deletion' with a patron who have a reading history. The reading history is still present. With patch, the same context, the reading history is deleted. Thx for testing
I believe it would be more proper to disable the "my privacy' tab if AnonymousPatron is not a valid patron. This would be more in line with how OPACPrivacy requires opacreadinghistory and the tab does not show if opacreadinghistory is not set to "Allow".
Created attachment 18864 [details] bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
The content of attachment 18864 [details] has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2013-06-12 21:47:50 NZST.
I don't see comments about the failed QA status ? An error ? So I move in need ...
oups sry Kyle, hum, you suggest to hide the tab in this case ... Ok I'll do a new patch in this way thx
*** This bug has been marked as a duplicate of bug 6756 ***