Bug 9744 - Add a column Fund name on the home page of acquisitions
Summary: Add a column Fund name on the home page of acquisitions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Maxime Pelletier
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 21:26 UTC by Maxime Pelletier
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch based on 3.8.5 (3.35 KB, patch)
2013-03-04 21:42 UTC, Maxime Pelletier
Details | Diff | Splinter Review
Patch based on master (3.67 KB, patch)
2013-03-04 22:28 UTC, Maxime Pelletier
Details | Diff | Splinter Review
Bug 9744 - Add a column Fund name on the home page of acquisitions (12.44 KB, patch)
2013-03-12 13:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9744 - Add a column Fund name on the home page of acquisitions (12.48 KB, patch)
2013-03-18 16:10 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9744 - Add a column Fund name on the home page of acquisitions (12.55 KB, patch)
2013-06-03 10:27 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Pelletier 2013-03-04 21:26:14 UTC
Here is a patch to add a column "Fund name" the the acquisition home. It also includes css to move the table below the content if the table is too big to fit in the page.
Comment 1 Maxime Pelletier 2013-03-04 21:42:25 UTC Comment hidden (obsolete)
Comment 2 Maxime Pelletier 2013-03-04 22:28:57 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-03-12 13:31:36 UTC Comment hidden (obsolete)
Comment 4 jmbroust 2013-03-18 10:50:45 UTC
I tried to test this patch with sandbox system, it does not work, here is the result : 

Applying: Bug 9744Add a column "Fund name" the the acquisition home.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 9744Add a column "Fund name" the the acquisition home.
Comment 5 Owen Leonard 2013-03-18 14:07:24 UTC
(In reply to comment #4)
> I tried to test this patch with sandbox system, it does not work

I have obsoleted the two other versions of this patch so that it can be tested on the sandbox. Please try again.
Comment 6 Paul Poulain 2013-03-18 16:09:44 UTC
Patch tested with a sandbox, by caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr>
Comment 7 Paul Poulain 2013-03-18 16:10:02 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2013-06-03 10:27:47 UTC
Created attachment 18616 [details] [review]
Bug 9744 - Add a column Fund name on the home page of acquisitions

This patch offers an alternative option to fix Bug 9744. In this version
the table of funds swaps positions with the suggestions block so that
the table has the whole width of the screen. This eliminates the need to
adjust its float property.

Other changes:

- Simplification of the column and row-hiding JavaScript
- The addition of an "Active" column to be shown when all funds
  are shown (this helps indicate to the user which rows were hidden)
- Linking the fund owner to their patron record
- Linking the fund id, given the correct permissions, to the view of all
  funds for that budget (the best alternative to linking to a view of
  the fund details, which we do not have).
- Correcting permission level required to add a budget

To test, view the acquisitions home page. The layout should feel
comfortable. The table of available funds thsould show the fund name.
The checkbox to show all funds should work correctly.

Signed-off-by: caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 9 Galen Charlton 2013-06-03 14:47:39 UTC
Pushed to master.  Thanks, Owen!