cleanborrowers.pl currently silently carries on if anonymisation fails due to the AnonymousPatron being left at its default or set incorrectly. If the proposed fix for bug 6506 is accepted, cleanborrowers.pl will "know about" any anonymisation errors as described in that bug. However, the patch for that bug does not cause cleanborrowers to fail or otherwise report this error, so it continues to silently fail in this case.
Still valid: 141 # Anonymising all members 142 if ($do_anonym) { 143 #FIXME: anonymisation errors are not handled 144 ($totalAno,my $anonymisation_error) = AnonymiseIssueHistory($last_issue_date); 145 $template->param( 146 do_anonym => '1', 147 ); 148 }
Note that bug 16966 will improve it a bit: the number of records anonymised will be displayed.
Code is different now, but the FIXME remained: # Anonymising all members 146 if ($do_anonym) { 147 #FIXME: anonymisation errors are not handled 148 my $rows = Koha::Old::Checkouts 149 ->filter_by_anonymizable 150 ->filter_by_last_update({ 151 to => $last_issue_date, timestamp_column_name => 'returndate' }) 152 ->anonymize; 153 154 $template->param( 155 do_anonym => $rows, 156 ); 157 } 158