Summary: | The budget list always shows my funds | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12958 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11578 | ||
Bug Blocks: | 12958, 12988 | ||
Attachments: |
Bug 12955: The "show my funds only" should be take into account
Bug 12955: The "show my funds only" should be take into account [PASSED QA] Bug 12955: The "show my funds only" should be take into account |
Description
Jonathan Druart
2014-09-18 10:25:06 UTC
Created attachment 31697 [details] [review] Bug 12955: The "show my funds only" should be take into account The "Show my funds only" is not take into account if the checkbox is not checked. So there is no way to show all funds. This has been introduced by bug 11578. The default is not "only mine". The default is "show all funds". Test plan: - Create fund where you are the owner and others where you are not. - Go on the fund list view and verify the checkbox "show my funds only" is take into account. This is quite critical for 3.16.x branch. Created attachment 31725 [details] [review] Bug 12955: The "show my funds only" should be take into account The "Show my funds only" is not take into account if the checkbox is not checked. So there is no way to show all funds. This has been introduced by bug 11578. The default is not "only mine". The default is "show all funds". Test plan: - Create fund where you are the owner and others where you are not. - Go on the fund list view and verify the checkbox "show my funds only" is take into account. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 32198 [details] [review] [PASSED QA] Bug 12955: The "show my funds only" should be take into account The "Show my funds only" is not take into account if the checkbox is not checked. So there is no way to show all funds. This has been introduced by bug 11578. The default is not "only mine". The default is "show all funds". Test plan: - Create fund where you are the owner and others where you are not. - Go on the fund list view and verify the checkbox "show my funds only" is take into account. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Note: In order to test this make sure you have funds owned by another staff user. My testing branch looked like this: Bug 12988: Update table footer with the~ Bug 12955: The "show my funds only" should be take into account Bug 12989: Fix JS error Bug 12989: Update table footer with the visible rows - acqui-home Bug 12984: Improvement of the funds list view - acqui home Bug 12987: The new format_price include file should be include on using... Bug 12987: Update table footer with the visible rows Bug 12986: Upgrade the DataTables jQuery plugin to the latest version (1.10.2) <master> Bug 12844: Force the symbol place in the tests Patch pushed to master. Thanks Jonathan! |