Bug 12958 - Set a fund owner to its children
Summary: Set a fund owner to its children
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 12955 12956
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-18 11:16 UTC by Jonathan Druart
Modified: 2015-06-04 23:32 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12958: Set a fund owner to a fund hierarchy (8.46 KB, patch)
2014-09-18 11:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12958 Followup, more 'gracious' UI? (1.60 KB, patch)
2014-10-27 15:12 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 12958: Set a fund owner to a fund hierarchy (8.53 KB, patch)
2014-10-27 15:13 UTC, Frédéric Demians
Details | Diff | Splinter Review
Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy (2.36 KB, patch)
2014-10-28 13:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Owen layout scrrenshot (6.52 KB, image/png)
2014-10-28 15:30 UTC, Frédéric Demians
Details
Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy (2.38 KB, patch)
2014-10-28 15:33 UTC, Frédéric Demians
Details | Diff | Splinter Review
[PASSED QA] Bug 12958: Set a fund owner to a fund hierarchy (8.60 KB, patch)
2014-10-28 19:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy (2.50 KB, patch)
2014-10-28 19:31 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-09-18 11:16:14 UTC
On editing a fund, it would facilitate to have the ability to select a owner for all the fund hierarchy.
Comment 1 Jonathan Druart 2014-09-18 11:23:07 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-09-18 11:24:44 UTC
Note that this patch does not depend on bug 12955 and bug 12956 but I recommend to test the enhancement with these bug fixes applied.
Comment 3 Frédéric Demians 2014-10-27 15:12:34 UTC Comment hidden (obsolete)
Comment 4 Frédéric Demians 2014-10-27 15:13:36 UTC Comment hidden (obsolete)
Comment 5 Frédéric Demians 2014-10-27 15:17:44 UTC
Note: patches 12956 & 12955 are required to apply this one.

Jonathan: You are the best placed to see if my UI rewording has any intersest.
Comment 6 Katrin Fischer 2014-10-28 07:45:59 UTC
Owen, could you take a look at the first = second GUI follow-up? 

I wonder if we should add a warning, that if the child funds already have an owner, this one will be overwritten.
Comment 7 Owen Leonard 2014-10-28 13:04:16 UTC Comment hidden (obsolete)
Comment 8 Frédéric Demians 2014-10-28 15:30:27 UTC
Created attachment 32846 [details]
Owen layout scrrenshot

Owen alt follow-up looks good to me. I obsolete mine, and sign his.
Comment 9 Frédéric Demians 2014-10-28 15:33:02 UTC Comment hidden (obsolete)
Comment 10 Katrin Fischer 2014-10-28 19:30:56 UTC
Created attachment 32855 [details] [review]
[PASSED QA] Bug 12958: Set a fund owner to a fund hierarchy

This patch adds the ability to set an owner to a fund hierarchy
On editing a fund, if it has children, a new checkbox appears "Set this
owner to all children funds".
If checked, all the fund hierarchy will herit to this owner.
This will facilitate the fund owner modifications.

Test plan:
- Verify that the new checkbox only appears if the fund has at least a child.
- Create a consistent fund hierarchy, something like:
    fund1
      fund11
        fund111
      fund12
    fund2
      fund21
- Try to modify a fund owner without checking the checkbox. Verify the
  children have not been modified.
- Try to modify a fund owner with checking the checkbox. Verify all fund
  hierarchy has been modified.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

It works as announced.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2014-10-28 19:31:19 UTC
Created attachment 32856 [details] [review]
[PASSED QA] Bug 12958 [Alt. label follow-up] Set a fund owner to a fund hierarchy

This alternate follow-up modifies the text of the label to
(hopefully) make it more clear. The markup has been revised someone to
make it more standard, and a warning has been added about overwriting
existing data.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>

Looks good.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Works as described, passes tests and QA script.
Comment 12 Tomás Cohen Arazi 2014-10-31 19:43:28 UTC
Patches pushed to master.

Thanks Jonathan and Owen!