Bug 13114

Summary: Disabled Shibboleth authentication spams logs
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: AuthenticationAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: dcook, dpavlin, f.demians, francart, indradg, martin.renvoize, mathsabypro, matthias.meusburger, paola.rossi, pgsengstock, tomascohen, ztajoli
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 8446, 13569    
Bug Blocks: 12680, 12681, 12682, 12026, 12027, 18507    
Attachments: Bug 13114: Prevent Shibboleth Patches from spamming logs
Bug 13114: Prevent Shibboleth Patches from spamming logs
[PASSED QA] Bug 13114: Prevent Shibboleth Patches from spamming logs

Description Martin Renvoize (ashimema) 2014-10-20 13:01:14 UTC
It appears the initial shibboleth authentication patch spams the logs with an undefined error when disabled.  This is a regression and we should keep the logs quiet (unless of course debug is set).

Sorry guys, patch coming soon.
Comment 1 Martin Renvoize (ashimema) 2014-10-20 13:07:40 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi (tcohen) 2014-10-20 13:11:57 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-21 22:02:40 UTC
Created attachment 32568 [details] [review]
[PASSED QA] Bug 13114: Prevent Shibboleth Patches from spamming logs

- The shibboleth patch introduced an undefined message into the error
  logs, when shiboleth is disabled.

Testplan

1. Ensure shibboleth is disabled.
2. Refresh any opac page
3. See 'Use of uninitialized value $ENV{"REMOTE_USER"} in string ne at
/home/koha/kohaclone/C4/Auth.pm line 711.' popup in the opac-error.log
4. Apply patch
5. Refresh opac page
6. Error should no longer appear

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.
Comment 4 Tomás Cohen Arazi (tcohen) 2014-10-22 00:13:28 UTC
Patch pushed to master.

Thanks Martin!