Shibboleth authentication has the ability to send an arbitrary number of attributes to koha; These attributes can be used to dynamically create (bug 12026) and update user records in koha. Our shibboleth patches should support the update/sync process as well as the create process.
Created attachment 79491 [details] [review] Bug 18507: Shibboleth auto-provisioning - Sync This patch allows to update borrowers informations with Shibboleth attributes upon login. Test plan: 1. In $KOHA_CONF, check that //shibboleth/sync is set to 1 2. Find an existing user and change one of the values mapped with a Shibboleth attribute 3. Log in using Shibboleth 4. Check that the value has been updated with the Shibboleth attribute.
Created attachment 79505 [details] [review] Bug 18507: Shibboleth auto-provisioning - Sync This patch allows to update borrowers informations with Shibboleth attributes upon login. Test plan: 1. In $KOHA_CONF, check that //shibboleth/sync is set to 1 2. Find an existing user and change one of the values mapped with a Shibboleth attribute 3. Log in using Shibboleth 4. Check that the value has been updated with the Shibboleth attribute. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Tested with starman and bug 17776. Works as expected.
Created attachment 81883 [details] [review] Bug 18507: Shibboleth auto-provisioning - Sync This patch allows to update borrowers informations with Shibboleth attributes upon login. Test plan: 1. In $KOHA_CONF, check that //shibboleth/sync is set to 1 2. Find an existing user and change one of the values mapped with a Shibboleth attribute 3. Log in using Shibboleth 4. Check that the value has been updated with the Shibboleth attribute. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Comments posted on Bugzilla.
Seems we have a bit of code duplication here between the add and modify case. Can we slide that into one routine ? No blocker on feature slush, open a new report please. Do we need to check somewhere if the key is a valid patron column btw? Is not done on create, so no blocker too. Looks good enough to go along now. Feature can simply be config disabled, so no harm. Only reviewed, not tested. But has been confirmed to work.
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.