It appears the initial shibboleth authentication patch spams the logs with an undefined error when disabled. This is a regression and we should keep the logs quiet (unless of course debug is set). Sorry guys, patch coming soon.
Created attachment 32531 [details] [review] Bug 13114: Prevent Shibboleth Patches from spamming logs - The shibboleth patch introduced an undefined message into the error logs, when shiboleth is disabled. Testplan 1. Ensure shibboleth is disabled. 2. Refresh any opac page 3. See 'Use of uninitialized value $ENV{"REMOTE_USER"} in string ne at /home/koha/kohaclone/C4/Auth.pm line 711.' popup in the opac-error.log 4. Apply patch 5. Refresh opac page 6. Error should no longer appear
Created attachment 32533 [details] [review] Bug 13114: Prevent Shibboleth Patches from spamming logs - The shibboleth patch introduced an undefined message into the error logs, when shiboleth is disabled. Testplan 1. Ensure shibboleth is disabled. 2. Refresh any opac page 3. See 'Use of uninitialized value $ENV{"REMOTE_USER"} in string ne at /home/koha/kohaclone/C4/Auth.pm line 711.' popup in the opac-error.log 4. Apply patch 5. Refresh opac page 6. Error should no longer appear Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 32568 [details] [review] [PASSED QA] Bug 13114: Prevent Shibboleth Patches from spamming logs - The shibboleth patch introduced an undefined message into the error logs, when shiboleth is disabled. Testplan 1. Ensure shibboleth is disabled. 2. Refresh any opac page 3. See 'Use of uninitialized value $ENV{"REMOTE_USER"} in string ne at /home/koha/kohaclone/C4/Auth.pm line 711.' popup in the opac-error.log 4. Apply patch 5. Refresh opac page 6. Error should no longer appear Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described.
Patch pushed to master. Thanks Martin!