Actually, this is effecting all pages where the "#searchheader" toolbar is present. (In reply to Lucas Gass from comment #1) > Actually, this is effecting all pages where the "#searchheader" toolbar is > present. Sure about that? On which other views do you recreate the problem? No, I may be wrong about that. I can only successfully recreate it on the lists view. On the mailing list (https://lists.katipo.co.nz/pipermail/koha/2018-October/051753.html) Elaine reported an overlap of the tabs on top of the toolbar, but I cannot recreate it. We could revert commit 592905a4d2d41a1a7b757c48fbac8fc6f025bf9b Bug 21139: (follow-up) Floating toolbars - Remove unecessary height But I would prefer to find a better fix as it degrades the ergonomic for FF Created attachment 81974 [details]
Screenshot of tabs in editing (staff interface)
There is also a display issue in the staff interface. The tabs are displaying strangely - covering the buttons (and less often, the buttons hide the tab numbers) when editing a catalogue record. But it's only a problem with some of the tabs: 1-4 and 8-9. The buttons and tabs still seem to function, but they don't display correctly. It also only seems to happen in Chrome (it works fine in Firefox). I'm testing this as a replacement for fixFloat and it looks very promising. https://github.com/somewebmedia/hc-sticky Created attachment 82346 [details] [review] Bug 21751: fixFloat toolbar not displaying properly in Chrome This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. - Authorities -> Create or edit an authority It all worked really well until this one. Not sure how to describe it! When scrolling down the form fields remain visible while scrolling through the floating toolbar? On the advanced search, click more options. Make the browser window width about half of he screen width. Scroll down - the toolbar vanishes when reaching the bottom. Tested in Chrome. I have tried just 2 (on Firefox): * http://pro.kohadev.org/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=5&categorycode=PT => JS error - "TypeError: c is null" hc-sticky_18.0600060.js:11:4777 * http://pro.kohadev.org/cgi-bin/koha/acqui/supplier.pl?booksellerid=1&op=enter => The toolbar is *behind* the other divs (!) https://screenshots.firefox.com/iWOtec6wmNaOTsbG/pro.kohadev.org Created attachment 82365 [details] [review] Bug 21751: fixFloat toolbar not displaying properly in Chrome This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. This amended patch includes a couple of tweaks and adds a step to the test plan: Regenerate the CSS. Created attachment 82908 [details] [review] Bug 21751: fixFloat toolbar not displaying properly in Chrome This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Maybe not blocker but it has the same issue we fixed with our previous changes: https://screenshots.firefox.com/wV9LmstgxSUSUcaZ/pro.kohadev.org The problem also exists and is more visible when editing a patron, and header filters are displayed. I think we will need to play with the "top" parameter of the plugin (readjust it when filters are hidden/shown). Created attachment 82924 [details] [review] Bug 21751: fixFloat toolbar not displaying properly in Chrome This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. (In reply to Jonathan Druart from comment #16) > Maybe not blocker but it has the same issue we fixed with our previous > changes I think this updated patch solves this problem. Created attachment 82925 [details] [review] Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 82926 [details] [review] Bug 21751: Remove former fixFloat plugin Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Owen Leonard from comment #19) > (In reply to Jonathan Druart from comment #16) > > Maybe not blocker but it has the same issue we fixed with our previous > > changes > > I think this updated patch solves this problem. Indeed, thanks! I amended the commit message of your patch to reflect what it actually does, I hope you are ok with it. Maybe not: when editing a record, the selector .main seems to not be the best one Created attachment 83292 [details] [review] Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 83293 [details] [review] Bug 21751: Remove former fixFloat plugin Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Hi Owen, working through the test plan using Chrome and Firefox on Ubuntu: - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too The floating toolbar doesn't work here for me in either browser. The toolbar stays fixed when scrolling. Lists -> View list - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Open the plugin window for the 008 field Would float in Firefox, but not in Chrome for me. Cleared the cache... maybe someone else can have a look? All other toolbars behaved as expected. Just confirming that I'm issues with the fixFloat plugin as well. I imagine this must be affecting a number of people in production? You could help by signing off bug 21813 ;) (In reply to Katrin Fischer from comment #29) > You could help by signing off bug 21813 ;) I thought it was already passed QA? Not when I commented - it has progressed since :) (In reply to Katrin Fischer from comment #31) > Not when I commented - it has progressed since :) Ahhh excellent! Created attachment 83731 [details] [review] Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Created attachment 83732 [details] [review] Bug 21751: Remove former fixFloat plugin I've run out of time today but I want to test this tomorrow. Thanks, Owen! Quick question: How does one "regenerate the staff client CSS"? (In reply to Owen Leonard from comment #37) > https://wiki.koha-community.org/wiki/ > Working_with_SCSS_in_the_OPAC_and_staff_client You're a champion, Owen. I'll take a look ASAP. Realized late last night I'm still doing half days so might need a bit more time to test this one.. Also going to be trying it in koha-testing-docker so wish me luck... this is awesome. one small note: when I apply this patch and go to cataloging > add record the #toolbar seems to loose its 'z-index' and displays underneath everything else instead of on top. Thanks for testing Lucas. Did you regenerate the staff client CSS before testing? All looks good to me using Chrome Version 71.0.3578.98 (Official Build) (64-bit) on Windows 10. Created attachment 84316 [details] [review] Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 84317 [details] [review] Bug 21751: Remove former fixFloat plugin Signed-off-by: David Cook <dcook@prosentient.com.au> I'd love for this to finally go in! But sadly, I found 2 that won't work for me: Acquisitions -> Vendor -> View basket Patrons -> New patron Error is the same: <TypeError: c is null[Learn More] hc-sticky_18.1200008.js:11:4777 Generated the CSS and did a restart_all... hope it's not something I've been missing. Tested with Firefox in Ubuntu. Created attachment 84476 [details] [review] Bug 21751: (follow-up) Correction to selectors This patch makes a couple of corrections to the selectors used by hcsticky in targeting the position of the floating toolbar. These changes were made necessary by changes made in recently-pushed patches. To test, confirm that these two pages work correctly: - Acquisitions -> Vendor -> View basket - Patrons -> New patron Created attachment 84500 [details] [review] Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 84501 [details] [review] Bug 21751: Remove former fixFloat plugin Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 84502 [details] [review] Bug 21751: (follow-up) Correction to selectors This patch makes a couple of corrections to the selectors used by hcsticky in targeting the position of the floating toolbar. These changes were made necessary by changes made in recently-pushed patches. To test, confirm that these two pages work correctly: - Acquisitions -> Vendor -> View basket - Patrons -> New patron Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 84660 [details] [review] Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display This patch replaces the fixFloat jQuery plugin with a new one: HC-sticky (https://github.com/somewebmedia/hc-sticky). This plugin provides the same functionality without the page-reflow problems fixFloat suffers from. To test, apply the patch and regenerate the staff client CSS. Test the behavior of the floating toolbar on these pages: - Acquisitions -> Vendor -> Vendor details - Acquisitions -> Vendor -> View basket - On both these pages, test toolbar behavior before and after expanding the "Orders search" options at the top of the page. - Administration -> System preferences - Authorities -> Create or edit an authority - Catalog -> Advanced search - Search results - Catalog -> Item search - Cataloging -> Add or edit a record - Open the plugin window for the 008 field - Tools -> Label creator -> New label batch -> Add items -> Search -> Results - Patrons -> New patron - Test before and after expanding the patron search options at the top of the page - Test editing a patron too - Tools -> Automatic item modifications by age -> Edit - Tools -> Notices & slips -> Edit - Lists -> View list Check that the About page has been updated with information about the plugin. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 84661 [details] [review] Bug 21751: Remove former fixFloat plugin Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 84662 [details] [review] Bug 21751: (follow-up) Correction to selectors This patch makes a couple of corrections to the selectors used by hcsticky in targeting the position of the floating toolbar. These changes were made necessary by changes made in recently-pushed patches. To test, confirm that these two pages work correctly: - Acquisitions -> Vendor -> View basket - Patrons -> New patron Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 This toolbar breaks /cgi-bin/koha/acqui/supplier.pl - I can't click anywhere on the form. I've made Bug 22293 for fixing this. I'm not going to backport this one at this time as it feels too close to an enhancement (and the backport is non-trivial). 19.05 enhancement. *** Bug 16905 has been marked as a duplicate of this bug. *** *** Bug 20857 has been marked as a duplicate of this bug. *** |
Created attachment 81830 [details] screenshot of public list in Chrome There is a display issue in Chrome (Firefox seems unaffected) at cgi-bin/koha/virtualshelves/shelves.pl The table header is overlapped by the toolbar (#searchheader) because of its absolute positioning. See attachment.