Bug 22045 - Cataloging UX enhancement - Improve access to tabs
Summary: Cataloging UX enhancement - Improve access to tabs
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 21751
Blocks:
  Show dependency treegraph
 
Reported: 2018-12-21 22:24 UTC by Lucas Gass
Modified: 2019-02-12 21:59 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
vertical displaying tabs (257.74 KB, image/png)
2018-12-21 22:24 UTC, Lucas Gass
Details
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.10 KB, patch)
2019-01-10 15:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.10 KB, patch)
2019-02-04 14:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.27 KB, patch)
2019-02-08 20:09 UTC, Mikaël Olangcay Brisebois
Details | Diff | Splinter Review
Bug 22045: (follow-up) Revert change to numbering of tabs (3.05 KB, patch)
2019-02-11 17:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.37 KB, patch)
2019-02-11 17:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22045: (follow-up) Revert change to numbering of tabs (3.05 KB, patch)
2019-02-11 17:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.48 KB, patch)
2019-02-11 18:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 22045: (follow-up) Revert change to numbering of tabs (3.15 KB, patch)
2019-02-11 18:47 UTC, David Nind
Details | Diff | Splinter Review
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.48 KB, patch)
2019-02-11 18:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 22045: (follow-up) Revert change to numbering of tabs (3.15 KB, patch)
2019-02-11 18:50 UTC, David Nind
Details | Diff | Splinter Review
Bug 22045: Cataloging UX enhancement - Improve access to tabs (9.48 KB, patch)
2019-02-11 18:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 22045: (follow-up) Revert change to numbering of tabs (3.15 KB, patch)
2019-02-11 18:51 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2018-12-21 22:24:54 UTC
Created attachment 83473 [details]
vertical displaying tabs

it would be nice if on the cat_addbiblio page the ui-tabs-nav (0-9 tabs) were either fixed OR also available at the bottom of the page so catalogers don't have to scroll all the way back up to the top of the page each time they want to switch tabs. 
I have experimented with displaying them vertical instead of horizontal, with a position of fixed.
Comment 1 Katrin Fischer 2018-12-23 09:57:52 UTC
I believe Owen was working on something similar for the cataloguing editor - adding him CC.
Comment 2 Owen Leonard 2019-01-02 15:21:14 UTC
This is what I was playing around with:

https://zivotdesign.com/p/#1/15223413373574

The section links would float along with the toolbar. There were some issues with it that I was still working out, so I'll have to rebase and take another look if it's interesting to folks.
Comment 3 Owen Leonard 2019-01-10 15:16:19 UTC
Created attachment 83770 [details] [review]
Bug 22045: Cataloging UX enhancement - Improve access to tabs

This patch makes style changes to the standard MARC editor with the goal
of both making it more responsive and making it easier to navigate among
tabs and tags.

Tabs are now part of the page's toolbar, which floats as the page
scrolls. In addition to the numbered tabs, there is also a section
showing in-page links to the MARC tags which are available on that page.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

Open a blank or existing record in the standard cataloging editor. Test
the redesigned tabs, the floating toolbar, and the in-page tag links.
Confirm that everything works well at various browser widths.
Comment 4 Maryse Simard 2019-01-11 20:33:34 UTC
I can't apply the patch.

Applying: Bug 22045: Cataloging UX enhancement - Improve access to tabs
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss).
error: could not build fake ancestor
Patch failed at 0001 Bug 22045: Cataloging UX enhancement - Improve access to tabs
Comment 5 Katrin Fischer 2019-01-11 20:36:29 UTC
Hi Maryse, this bug depends on bug 21751, it needs to be applied and tested first.
Comment 6 Owen Leonard 2019-02-04 14:54:59 UTC Comment hidden (obsolete)
Comment 7 Mikaël Olangcay Brisebois 2019-02-08 20:09:12 UTC Comment hidden (obsolete)
Comment 8 Mikaël Olangcay Brisebois 2019-02-08 20:10:08 UTC
It's a really nice UX enhancement, only thing I would modify is the numbering. It should start from 0 instead of 1.
Comment 9 Owen Leonard 2019-02-11 13:51:44 UTC
(In reply to Mikaël Olangcay Brisebois from comment #8)
> It's a really nice UX enhancement, only thing I would modify is the
> numbering. It should start from 0 instead of 1.

My intention was to make the number more user-friendly, since normal people don't start counting at zero. However, I didn't consider that the MARC framework editor would have to be changed at the same time, so I'll have to save that for another bug.
Comment 10 Owen Leonard 2019-02-11 17:32:15 UTC Comment hidden (obsolete)
Comment 11 Owen Leonard 2019-02-11 17:33:40 UTC
Created attachment 84985 [details] [review]
Bug 22045: Cataloging UX enhancement - Improve access to tabs

This patch makes style changes to the standard MARC editor with the goal
of both making it more responsive and making it easier to navigate among
tabs and tags.

Tabs are now part of the page's toolbar, which floats as the page
scrolls. In addition to the numbered tabs, there is also a section
showing in-page links to the MARC tags which are available on that page.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

Open a blank or existing record in the standard cataloging editor. Test
the redesigned tabs, the floating toolbar, and the in-page tag links.
Confirm that everything works well at various browser widths.

Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
Comment 12 Owen Leonard 2019-02-11 17:33:44 UTC
Created attachment 84986 [details] [review]
Bug 22045: (follow-up) Revert change to numbering of tabs

I wanted the tabs to be numbered like humans count, starting from 1.
But if the MARC framework setup isn't changed as well it doesn't make
sense. This patch removes the change.

Also fixed: Some missing template filters, an errant console.log()
removed.

To test, apply the patch and open a new or existing record for
editing. The tabs (now "Sections") should be labeled from 0-9.
Comment 13 David Nind 2019-02-11 18:47:18 UTC
Created attachment 84993 [details] [review]
Bug 22045: Cataloging UX enhancement - Improve access to tabs

This patch makes style changes to the standard MARC editor with the goal
of both making it more responsive and making it easier to navigate among
tabs and tags.

Tabs are now part of the page's toolbar, which floats as the page
scrolls. In addition to the numbered tabs, there is also a section
showing in-page links to the MARC tags which are available on that page.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

Open a blank or existing record in the standard cataloging editor. Test
the redesigned tabs, the floating toolbar, and the in-page tag links.
Confirm that everything works well at various browser widths.

Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>

Signed-off-by: John Doe <you@example.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 14 David Nind 2019-02-11 18:47:22 UTC
Created attachment 84994 [details] [review]
Bug 22045: (follow-up) Revert change to numbering of tabs

I wanted the tabs to be numbered like humans count, starting from 1.
But if the MARC framework setup isn't changed as well it doesn't make
sense. This patch removes the change.

Also fixed: Some missing template filters, an errant console.log()
removed.

To test, apply the patch and open a new or existing record for
editing. The tabs (now "Sections") should be labeled from 0-9.

Signed-off-by: John Doe <you@example.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 15 David Nind 2019-02-11 18:50:19 UTC
Created attachment 84995 [details] [review]
Bug 22045: Cataloging UX enhancement - Improve access to tabs

This patch makes style changes to the standard MARC editor with the goal
of both making it more responsive and making it easier to navigate among
tabs and tags.

Tabs are now part of the page's toolbar, which floats as the page
scrolls. In addition to the numbered tabs, there is also a section
showing in-page links to the MARC tags which are available on that page.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

Open a blank or existing record in the standard cataloging editor. Test
the redesigned tabs, the floating toolbar, and the in-page tag links.
Confirm that everything works well at various browser widths.

Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 16 David Nind 2019-02-11 18:50:23 UTC
Created attachment 84996 [details] [review]
Bug 22045: (follow-up) Revert change to numbering of tabs

I wanted the tabs to be numbered like humans count, starting from 1.
But if the MARC framework setup isn't changed as well it doesn't make
sense. This patch removes the change.

Also fixed: Some missing template filters, an errant console.log()
removed.

To test, apply the patch and open a new or existing record for
editing. The tabs (now "Sections") should be labeled from 0-9.

Signed-off-by: John Doe <you@example.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 17 David Nind 2019-02-11 18:51:35 UTC
Created attachment 84997 [details] [review]
Bug 22045: Cataloging UX enhancement - Improve access to tabs

This patch makes style changes to the standard MARC editor with the goal
of both making it more responsive and making it easier to navigate among
tabs and tags.

Tabs are now part of the page's toolbar, which floats as the page
scrolls. In addition to the numbered tabs, there is also a section
showing in-page links to the MARC tags which are available on that page.

To test, apply the patch, regenerate the staff client CSS, and clear
your browser cache if necessary.

Open a blank or existing record in the standard cataloging editor. Test
the redesigned tabs, the floating toolbar, and the in-page tag links.
Confirm that everything works well at various browser widths.

Signed-off-by: Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 18 David Nind 2019-02-11 18:51:39 UTC
Created attachment 84998 [details] [review]
Bug 22045: (follow-up) Revert change to numbering of tabs

I wanted the tabs to be numbered like humans count, starting from 1.
But if the MARC framework setup isn't changed as well it doesn't make
sense. This patch removes the change.

Also fixed: Some missing template filters, an errant console.log()
removed.

To test, apply the patch and open a new or existing record for
editing. The tabs (now "Sections") should be labeled from 0-9.

Signed-off-by: John Doe <you@example.com>

Signed-off-by: David Nind <david@davidnind.com>
Comment 19 David Nind 2019-02-11 19:34:18 UTC
Apologies, I couldn't figure out how to git rid of "John Doe" for attachment 84998 [details] [review].
Comment 20 Josef Moravec 2019-02-12 21:59:35 UTC
Sometimes we have frameworks with some sections empty, this UI adapts well, but I can't change the tabs on biblio with such framework.

Otherwise it looks good and much cleaner the before. I like it