|
Description
Kelly McElligott
2019-09-25 00:35:13 UTC
*** Bug 22185 has been marked as a duplicate of this bug. *** Agreed. The Transactions table on boraccount.pl should allow one to add notes and/or edit existing notes. It's not a bad idea, but, as a system administrator for 51 libraries all using 1 shared Koha, I would want some control over who was able to edit notes. We use custom jQuery to add usernames and branchcodes to all notes so any staff member can easily look at an accountline and know who created it an where so that they don't have to run a report to see, for example, if someone at another library did a writeoff without permission from the library that owns that accountline. If anyone can edit any note, it makes it possible for someone to edit out the history of any undeserved writeoffs or credits they've created. I would want to be able to control who can edit the accountlines notes. A staff permission would be preferable, but a system preference would work too. Changed the bug title to reflect a broadened scope. Every accountlines entry has a notes field, so why not just put an Edit Note option on every line in the Transactions table. As George says, we'd want access to that button to be tied to a specific permission. Yes. Ability to add and edit notes is needed. Ability to extend "permissions" to that module for making/editing notes (and/or like in the Messages on patron's accounts where it gives the librarian, date, and time for the message when entered or edited) would be excellent, too [especially for the big wigs, like George ;-)] Created attachment 168035 [details] [review] Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Created attachment 168036 [details] [review] Bug 23674: Add ability to add a note to pay individual fine from paycollect.tt Place where we need to have the ability to add a note: Pay individual Write-off individual Void Issue refund Issue payout Apply discount Created attachment 168174 [details] [review] Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Created attachment 168177 [details] [review] Bug 23674: Add ability to add a note to issue refund Created attachment 168178 [details] [review] Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Created attachment 168180 [details] [review] Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. *** Bug 24597 has been marked as a duplicate of this bug. *** Created attachment 168213 [details] [review] Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Created attachment 168329 [details] [review] Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Created attachment 168330 [details] [review] Bug 23674: Fix duplicate ID's and label Created attachment 169782 [details] [review] Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169783 [details] [review] Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169784 [details] [review] Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169785 [details] [review] Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169786 [details] [review] Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169787 [details] [review] Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169788 [details] [review] Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Test notes: Test for "Bug 23674: Add ability to add a note to issue payout" works as described at the end, with full patchset. QA script: WARN members/boraccount.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 45, now: 46) WARN members/cancel-charge.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 4, now: 6) Patch no longer applies due to Bootstrap 5 changes Created attachment 174300 [details] [review] Bug 23674: Account for Bootstrap5 changes Created attachment 174301 [details] [review] Bug 23674: Add ability to add a note to APPLY DISCOUNT To test: 1. APPLY PATCH and restart_all 2. Apply a manual invoice to a patron account. 3. Go to the patron record -> accounting -> transaction tab 4. Look for the 'Apply discount' button. 5. When the 'Apply discount' modal appears notcie the 'Note' field. 6. Add a note, make sure it gets applied to this accountline. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174302 [details] [review] Bug 23674: Add ability to add a note to pay individual and write-off individual To test: 1) Apply manual invoice to a patron account 2) Go to the patron record -> accounting -> transaction tab 3) Look for the "Pay" button under the actions column. Click this 4) Notice no place to enter note 5) Click the "Write off" button. Notice there is no place to enter note 6) Apply patch, restart_all 7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs. 8) Write a not in the pay tab and confirm. Make sure this not shows up in the table. 9) Add another invoice and then test the note functionallity for the write-offs. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174303 [details] [review] Bug 23674: Add ability to add a note to issue payout To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 3) Under the actions column, select 'Issue Payout' 4) You can now enter a note. Type something in and press confirm. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174304 [details] [review] Bug 23674: Add ability to add note to void payment To test: 1) From patron accounting page -> Create manual credit. Put in some amount and press add credit. 2) Under the actions column, select "Void" 3) Notice no option for a note. Press cancel 4) Apply patch, restart_all 5) Press void again. This time, you should see a modal that gives you the option to type in a note. 6) Type something in and select submit. 7) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174305 [details] [review] Bug 23674: Add ability to add a note to issue refund To test: 1) Apply patch, restart_all 2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm. 3) In the transactions tab, for the invoice you just created, under the actions column select issue refund. 4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm. 5) Ensure the note correctly shows in the table. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174306 [details] [review] Bug 23674: Add ability to add note to canceled charge To test, with this patchset applied: 1) From patron accounting page -> Add a manual invoice 2) Under the transaction tab click 'Cancel charge' 3) You should see a modal that gives you the option to type in a note. 4) Type something in and select submit. 5) Ensure the note shows up in the note column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174307 [details] [review] Bug 23674: Fix duplicate ID's and label Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 174308 [details] [review] Bug 23674: Account for Bootstrap5 changes |