Summary: | When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Victor Grousset/tuxayo <victor> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, fiona.borthwick, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.01,20.05.07
|
|
Circulation function: | |||
Bug Depends on: | 14697 | ||
Bug Blocks: | |||
Attachments: |
Bug 25583: Disable the "claim returned" button if the feature is disabled
Bug 25583: Disable the "claim returned" button if the feature is disabled Bug 25583: Disable the "claim returned" button if the feature is disabled Bug 25583: (QA follow-up) Rephrase tooltip Bug 25583: Improve wording |
Description
Katrin Fischer
2020-05-22 11:06:40 UTC
*** Bug 25518 has been marked as a duplicate of this bug. *** In master at least, you cannot click "claim returned" if the pref is not set. I am not sure this is (still) valid. Can you close or clarify? I just retested on master, this is what I see: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts - Click "Claim returned" - Modal opens - Make claim (submit) - The item is now "claimed returned" in the checkouts tab, but the claims tab is not showing This is sort of at odds with bug 24767, in which we hid the claims tab if the value is not set. Katrin, your test plan sort of sneaks up on Claims, by using the Columns button to show the Return Claims column that would otherwise be hidden. Is the answer here to just not allow one to reveal the claims column at all when ClaimReturnedLostValue is not set? Created attachment 113867 [details] [review] Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled Created attachment 113878 [details] [review] Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 114108 [details] [review] Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> It works :) About the phrasing, should we say "Claim returned is disabled" or "Return claims are disabled"? Created attachment 114245 [details] [review] Bug 25583: (QA follow-up) Rephrase tooltip Here is an optional follow-up to rephrase with "Return claims are disabled" Release manager can pick this phrasing or the original one. I did a poll on IRC and got only one participant so not sure which is best. Created attachment 114276 [details] [review] Bug 25583: Improve wording < kidclamp> yeah, the phrase is a little awkward either way but I think it makes sense < Joubu> what would be a less awkward phrase? * ashimema reads < kidclamp> 'Claim returned' has become a thing in libraries, I think that is what makes it awkward, that those two words now go together as a pair < kidclamp> "Claim an item was returned" 'Claim this issue was returned" - its shorthand for things like that < ashimema> I think without the patch is better personally.. < ashimema> as it matches the content of the later string < ashimema> 'Claim returned' and 'Claim returned is disabled' feel like they go together < ashimema> could even be 'This is disabled' < Joubu> "This feature is disabled"? < ashimema> that would work for me :) < kidclamp> "ClaimReturnedLostValue is not set, this feature is disabled" Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.01 Pushed to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |