Bug 25134 - Return claims column should not be shown if ClaimReturnedLostValue is not set to a valid value
Summary: Return claims column should not be shown if ClaimReturnedLostValue is not set...
Status: RESOLVED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 14697
Blocks:
  Show dependency treegraph
 
Reported: 2020-04-13 16:43 UTC by Owen Leonard
Modified: 2024-01-01 14:32 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2020-04-13 16:43:37 UTC
In the checkouts table shown on circulation and patron details the "Return claims" column should be wrapped in a conditional checking for the presence of a value in the ClaimReturnedLostValue system preference.
Comment 1 Owen Leonard 2020-04-13 17:02:41 UTC
This bug might be dependent on Bug 24768? I'm confused by what's going on.
Comment 2 Katrin Fischer 2020-04-13 17:12:46 UTC
I thought it would be the easiest fix to add it to column configuration, because I wanted to be able to hide it for libraries not wanting to use it (it takes up quite a bit of space). Not sure if a conditional check would mean additional work is needed on not bug 24768.
Comment 3 Andrew Fuerste-Henry 2020-06-10 13:54:02 UTC
Katrin, you also filed bug 25583, about how the Claims tab doesn't show if ClaimReturnedLostValue isn't set. If we make the return claims column also not show, does that resolve your issue in 25583? If both the column and the tab hid themselves when the syspref isn't set, then one wouldn't be able to generate a claim one was then unable to manage.
Comment 4 Barbara Johnson 2020-10-14 20:18:52 UTC
At the moment we're not using the Claims Returned feature because it doesn't work with our local policies.  Our ClaimReturnedLostValue is not set but we still see the Claims tab on circulation and patron details.  We agree that the tab should be hidden when the syspref isn't set because it is confusing to staff.
Comment 5 Barbara Johnson 2020-10-14 20:52:50 UTC
Never mind my previous comment.  We discovered we had a blank space in the ClaimReturnedLostValue so that's why it was displaying.  So nothing to see here.
Comment 6 Andrew Fuerste-Henry 2020-10-14 21:01:01 UTC
But, following Barbara's comment, it might not be unreasonable to only show the Claims Returned controls if the syspref contains a *valid* lost value.
Comment 7 Jonathan Druart 2020-10-15 09:08:43 UTC
I don't recreate the original issue described in comment 0.

(In reply to Andrew Fuerste-Henry from comment #6)
> But, following Barbara's comment, it might not be unreasonable to only show
> the Claims Returned controls if the syspref contains a *valid* lost value.

I would suggest a check and warning on the about page instead.

Should we update the bug report's title?
Comment 8 Michaela Sieber 2023-09-01 18:32:57 UTC
I believe this is still valid.
I see the claims tab although ClaimReturnedLostValue is emty (and no blank space)
Comment 9 Katrin Fischer 2023-10-28 18:03:00 UTC
I believe the claims tab is now also used for the item bundle feature, so that might explain some change in behavior/might have taken into account.
Comment 10 Katrin Fischer 2024-01-01 14:32:04 UTC
This works if both BundleLostValue and ClaimReturnedLostValue are empty.