Bug 31810

Summary: Place hold button should be yellow
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, gmcharlt, lucas, m.de.rooy, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31884
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31812
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31888
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 31947    
Attachments: Bug 31810: Define 'Place hold' button as primary
Bug 31810: Define 'Place hold' button as primary
Bug 31810: Define 'Place hold' button as primary

Description Katrin Fischer 2022-10-15 07:37:58 UTC
When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.
Comment 1 Fridolin Somers 2022-10-20 01:28:58 UTC
I see Bug 23957 changed from input to button
Comment 2 Fridolin Somers 2022-10-20 01:41:52 UTC
Looks like important action button must use btn-primary instead of btn-default

https://getbootstrap.com/docs/4.0/components/buttons/#examples
Comment 3 Fridolin Somers 2022-10-20 01:49:34 UTC
Created attachment 142220 [details] [review]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available
Comment 4 Fridolin Somers 2022-10-20 01:50:45 UTC
We see this patch did the same on preferences page :
Bug 30952: Set preferences save buttons as primary buttons
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141679
Comment 5 David Nind 2022-10-20 02:34:59 UTC
Created attachment 142223 [details] [review]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Marcel de Rooy 2022-10-21 07:03:15 UTC
Fridolin: penalty points for not filling Assignee field. You should know.
Comment 7 Marcel de Rooy 2022-10-21 07:03:48 UTC
Not sure if a yellow button on a green form is the most optimal choice of colors. But its all a matter of taste :)
Comment 8 Marcel de Rooy 2022-10-21 07:04:24 UTC
Created attachment 142294 [details] [review]
Bug 31810: Define 'Place hold' button as primary

When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form.

Patch changes this button from btn-default to btn-primary.

Test plan :
Play with placing hold, one and several, with cases :
- normal
- override required
- none available

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Tomás Cohen Arazi 2022-10-21 12:58:57 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2022-10-21 19:29:10 UTC
(In reply to Marcel de Rooy from comment #6)
> Fridolin: penalty points for not filling Assignee field. You should know.

Oupsy, I need more coffee (or more IPA) ^^
Tanks for fixing