|
Description
Katrin Fischer
2022-10-15 07:37:58 UTC
Looks like important action button must use btn-primary instead of btn-default https://getbootstrap.com/docs/4.0/components/buttons/#examples Created attachment 142220 [details] [review] Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available We see this patch did the same on preferences page : Bug 30952: Set preferences save buttons as primary buttons https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141679 Created attachment 142223 [details] [review] Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind <david@davidnind.com> Fridolin: penalty points for not filling Assignee field. You should know. Not sure if a yellow button on a green form is the most optimal choice of colors. But its all a matter of taste :) Created attachment 142294 [details] [review] Bug 31810: Define 'Place hold' button as primary When placing a hold in staff, the 'Place hold' button should be yellow for the most important action on this form. Patch changes this button from btn-default to btn-primary. Test plan : Play with placing hold, one and several, with cases : - normal - override required - none available Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 22.11. Nice work everyone, thanks! (In reply to Marcel de Rooy from comment #6) > Fridolin: penalty points for not filling Assignee field. You should know. Oupsy, I need more coffee (or more IPA) ^^ Tanks for fixing |