Bug 31888 - In Elasticsearch mappings page save button should be yellow
Summary: In Elasticsearch mappings page save button should be yellow
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31947
  Show dependency tree / graph
 
Reported: 2022-10-20 08:28 UTC by Fridolin Somers
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31888: Define save button as primary in Elasticsearch mappings page (1.64 KB, patch)
2022-10-20 08:34 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 31888: Define save button as primary in Elasticsearch mappings page (1.69 KB, patch)
2022-10-20 13:18 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31888: Define save button as primary in Elasticsearch mappings page (1.75 KB, patch)
2022-10-21 08:35 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-10-20 08:28:40 UTC 
Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.
Comment 1 Fridolin Somers 2022-10-20 08:34:46 UTC 
Created attachment 142231 [details] [review]
Bug 31888: Define save button as primary in Elasticsearch mappings page

Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.

Test plan :
Go to Administration > Search engine configuration (Elasticsearch)
=> Check save button has class btn-primary and is yellow
Comment 2 David Nind 2022-10-20 13:18:35 UTC 
Created attachment 142243 [details] [review]
Bug 31888: Define save button as primary in Elasticsearch mappings page

Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.

Test plan :
Go to Administration > Search engine configuration (Elasticsearch)
=> Check save button has class btn-primary and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2022-10-21 08:35:24 UTC 
Created attachment 142304 [details] [review]
Bug 31888: Define save button as primary in Elasticsearch mappings page

Like Bug 31810, save button in Elasticsearch mappings page is the most important action on this form, it should be yellow.

Test plan :
Go to Administration > Search engine configuration (Elasticsearch)
=> Check save button has class btn-primary and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-10-24 14:46:10 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!