As I undertand, the main action on a page should have a yellow button - no yellow buttons on the manage staged imports page.
You mean /cgi-bin/koha/tools/manage-marc-import.pl ? I only see a table, there is no main action I think. On a batch /cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=1 I see 2 input type=submit already yellow
i meant one step earlier, when you stage: * Upload file * Stage for import
Possibly really meant something else when first filing this, but this looks good now.
Created attachment 142512 [details] [review] Bug 31812: Update 'Stage for import' button to be primary This patch updates the 'Stage for import' input to be of type="submit" and classes is a "button".. This gives it the yellow main action hinting.
Created attachment 142541 [details] [review] Bug 31812: Update 'Stage for import' button to be primary This patch updates the 'Stage for import' input to be of type="submit" and classes is a "button".. This gives it the yellow main action hinting. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 142542 [details] [review] Bug 31812: Update 'Stage for import' button to be primary This patch updates the 'Stage for import' input to be of type="submit" and classes is a "button".. This gives it the yellow main action hinting. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I feel like the upload file button should be yellow too, as we only see this one at first, what do you think?
Pushed to master for 22.11. Nice work everyone, thanks!
(In reply to Katrin Fischer from comment #7) > I feel like the upload file button should be yellow too, as we only see this > one at first, what do you think? Looks like this was missed before push? Perhaps a new bug so we don't lose it?
(In reply to Martin Renvoize from comment #9) > (In reply to Katrin Fischer from comment #7) > > I feel like the upload file button should be yellow too, as we only see this > > one at first, what do you think? Fixed by Bug 32096: Consistent classes for primary buttons: Tools