Description
Jonathan Druart
2023-02-17 10:58:57 UTC
Created attachment 146828 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Created attachment 146829 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Patches applied on top of the tree at https://gitlab.com/joubu/Koha/-/commits/bug_32991 Created attachment 147051 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Created attachment 147052 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Created attachment 147053 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Created attachment 147054 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Created attachment 147082 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 147083 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> (In reply to Jonathan Druart from comment #6) > Finally, there is something weird in Main.vue we need to fix. The > console is showing a warning > "[Vue warn]: setup() return property "_is_loading" should not start with "$" > or "_" which are reserved prefixes for Vue internals." This appears to just need a new variable name - Vue won't accept variables prefixed with "_" in root components so "_is_loading" will need renaming. We can't just remove the "_" as there is a getter called "is_loading" and this will conflict. Maybe "content_is_loading"? (In reply to Matt Blenkinsop from comment #10) > (In reply to Jonathan Druart from comment #6) > > > Finally, there is something weird in Main.vue we need to fix. The > > console is showing a warning > > "[Vue warn]: setup() return property "_is_loading" should not start with "$" > > or "_" which are reserved prefixes for Vue internals." > > This appears to just need a new variable name - Vue won't accept variables > prefixed with "_" in root components so "_is_loading" will need renaming. We > can't just remove the "_" as there is a getter called "is_loading" and this > will conflict. Maybe "content_is_loading"? Yes, the thing is that Agustin decided to prefix the store variables with '_', to get a good getter method name. We should not only rename is_loading, but others as well (for consistency), and so we need to provide a clean solution for all of them. But first I wanted to make sure the trick in Main was necessary and there was no better alternative. Created attachment 147281 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 147282 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Rebased on top of bug 32983's last changes. Created attachment 147291 [details] [review] Bug 32991: (QA follow-up) Add margin to buttons; Fix duplicate HTML element ID Created attachment 147305 [details] [review] Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Putting this back to NSO, it's causing Cypress tests to fail. I'm working on it. Also need to: - Remove no longer needed Vue files - Abstract the dialog button labels to be set by whatever component that invokes it, i.e. "Yes, delete" instead of the current hard-coded "Accept", etc. - Fix the "is_loading" console error Created attachment 147350 [details] [review] Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates Created attachment 147383 [details] [review] Bug 32991: accept is a callback, rename accept to accept_callback Created attachment 147384 [details] [review] Bug 32991: Allow for a confirmation title and a confirmation message in the dialog Created attachment 147385 [details] [review] Bug 32991: Add delete dialog to licenses list Created attachment 147387 [details] [review] Bug 32991: Allow for a confirmation title and a confirmation message in the dialog Created attachment 147388 [details] [review] Bug 32991: Add delete dialog to licenses list Created attachment 147389 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog Created attachment 147390 [details] [review] Bug 32991: Add delete dialog to licenses list Created attachment 147391 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog Created attachment 147392 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog Created attachment 147393 [details] [review] Bug 32991: Add delete dialog to licenses list Created attachment 147394 [details] [review] Bug 32991: Add delete dialog to local packages list Created attachment 147429 [details] [review] Bug 32991: Add delete dialog to local titles list Created attachment 147439 [details] [review] Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Created attachment 147445 [details] [review] Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Created attachment 147447 [details] [review] Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Created attachment 147448 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Created attachment 147449 [details] [review] Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Created attachment 147450 [details] [review] Bug 32991: accept is a callback, rename accept to accept_callback Created attachment 147451 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Created attachment 147452 [details] [review] Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Created attachment 147453 [details] [review] Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Created attachment 147454 [details] [review] Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Created attachment 147455 [details] [review] Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Created attachment 147456 [details] [review] Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates Created attachment 147461 [details] [review] Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Created attachment 147483 [details] [review] Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Created attachment 147485 [details] [review] Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Created attachment 147486 [details] [review] Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Created attachment 147487 [details] [review] Bug 32991: Add cypress tests for the dialog box Created attachment 147542 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147543 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147544 [details] [review] Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147545 [details] [review] Bug 32991: accept is a callback, rename accept to accept_callback Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147546 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147547 [details] [review] Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147548 [details] [review] Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147549 [details] [review] Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147550 [details] [review] Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147551 [details] [review] Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147552 [details] [review] Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147553 [details] [review] Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 147554 [details] [review] Bug 32991: Add cypress tests for the dialog box Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Added my stamp to Pedro's patches. Created attachment 147569 [details] [review] Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Hi Jonathan and Pedro! Excellent job on this Dialog component. I added a little fix on 'Main.vue' to not depend on the '_is_loading' flag I believe we can squash these commits now. Created attachment 147573 [details] [review] Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 147584 [details] [review] Bug 32991: Don't display breadcrumb if pref is off Thanks, Agustín! Created attachment 147588 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147589 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147590 [details] [review] Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147591 [details] [review] Bug 32991: accept is a callback, rename accept to accept_callback Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147592 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147593 [details] [review] Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147594 [details] [review] Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147595 [details] [review] Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147596 [details] [review] Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147597 [details] [review] Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147598 [details] [review] Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147599 [details] [review] Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147600 [details] [review] Bug 32991: Add cypress tests for the dialog box Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147601 [details] [review] Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147602 [details] [review] Bug 32991: Don't display breadcrumb if pref is off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147603 [details] [review] Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147604 [details] [review] Bug 32991: Don't display breadcrumb if pref is off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Rebased on top of 32983 to integrate the prettier change. Added Agustín and Pedro signed-off-by lines and considering this set PQA. Thanks! \o/ Created attachment 147937 [details] [review] Bug 32991: Improve our Dialog component This is picking some improvements made by Agustin on bug 32607. This patch is only a POC and we should apply this change to the different delete route. We will then remove the *FormConfirmDelete components, and the /delete routes Initially I wanted to have the same behaviour as in other areas of Koha, and have a separate view for the deletion step. But it's too much overhead for not much gain. Additionally we will have to remove messages.js, the aim of this file was to import the methods to add messages very easily (only 1 import line). Now we will need 2 lines (it was more when I added messages.js, because I didn't inject the store). Not a big deal. Finally, there is something weird in Main.vue we need to fix. The console is showing a warning "[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals." I had a hard time to display this "loading" modal when the app is loading all the things it needs. Pinia/store is not available as we are accessing the methods/actions too earlier. It will be good to fix that before we decide to move forward with this approach. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147938 [details] [review] Bug 32991: Add a confirmation message Looks easier to have a separate variable for the confirmation box, and easier for styling as well. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147939 [details] [review] Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147940 [details] [review] Bug 32991: accept is a callback, rename accept to accept_callback Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147941 [details] [review] Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147942 [details] [review] Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147943 [details] [review] Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147944 [details] [review] Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147945 [details] [review] Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147946 [details] [review] Bug 32991: Fix cypress tests. Added new test for when deleting from show view. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147947 [details] [review] Bug 32991: Flag the deletion messages as displayed already Or they will be displayed again on the next view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147948 [details] [review] Bug 32991: Don't remove all messages when confirm box is closed If we cancel the confirmation box we should not clear all the messages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147949 [details] [review] Bug 32991: Add cypress tests for the dialog box Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147950 [details] [review] Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Created attachment 147951 [details] [review] Bug 32991: Don't display breadcrumb if pref is off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io> Rebased patches that didn't apply Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport |