To recreate: 1 - Enable ERM 2 - View Agreements page: Uncaught (in promise) ReferenceError: logged_in_user is not defined 3 - Click on Licenses Uncaught (in promise) TypeError: node is null
Wrong resolution conflict on AgreementsList.vue in commit Bug 32991: Improve our Dialog component in master logged_in_user, + setWarning, + setMessage, in 22.11.x + logged_in_user, + setWarning, + setMessage,
Created attachment 150561 [details] [review] Bug 33648: (bug 32991 follow-up) fix bad resolution conflict Wrong resolution conflict on AgreementsList.vue in commit Bug 32991: Improve our Dialog component in master logged_in_user, + setWarning, + setMessage, in 22.11.x + logged_in_user, + setWarning, + setMessage,
Thanks for the quick fix Jonathan.
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Adding now and will ask Mason to role a 22.11.05-1 package for us to include this.
Created attachment 150830 [details] [review] Bug 33684: Make mandatory date fields required when editing a patron Date fields in BorrowerMandatoryField are not required by the validation form when a new patron is added or modified. This is because the 'required' prop does not exist on the input element when the flatpickr instance is created. We should either add it in the DOM directly (tt), but it will require to do it "manually" for each date fields, or add it when we add it to the inputs. This patch implements the second option. Test plan: 1. Add "dateofbirth" to syspref BorrowerMandatoryField. 2. Add patron and leave date of birth input field empty. 3. Save. => Form is not submitted and you are asked to fill in a date of birth Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment on attachment 150830 [details] [review] Bug 33684: Make mandatory date fields required when editing a patron Bug number typo, sorry for the noise