Summary: | Add Koha::Biblio->ratings | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00
|
Circulation function: | |
Bug Depends on: | 33952 | ||
Bug Blocks: | 33949, 33954 | ||
Attachments: |
Bug 33953: Adjust tests
Bug 33953: Koha::Biblio->ratings Bug 33953: Adjust tests Bug 33953: Koha::Biblio->ratings Bug 33953: Adjust tests Bug 33953: Koha::Biblio->ratings |
Description
Jonathan Druart
2023-06-08 10:11:19 UTC
Created attachment 152148 [details] [review] Bug 33953: Adjust tests Created attachment 152149 [details] [review] Bug 33953: Koha::Biblio->ratings Created attachment 152720 [details] [review] Bug 33953: Adjust tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 152721 [details] [review] Bug 33953: Koha::Biblio->ratings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great to see these relations being added.. going straight for a PQA here as it's a trivial patch and is working exactly as expected. Passing QA I'd like to push it, but depends on another (unrelated?) patchset. (In reply to Tomás Cohen Arazi from comment #6) > I'd like to push it, but depends on another (unrelated?) patchset. It prevents a conflict on t/db_dependent/Koha/Biblio.t This is needed for bug 33947 where we need to call ->ratings on a Koha::Biblio object. Created attachment 153411 [details] [review] Bug 33953: Adjust tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 153412 [details] [review] Bug 33953: Koha::Biblio->ratings Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Not required for anything in 23.05.x series yet, we can backport later if it becomes required. |