Bug 34324

Summary: Merge OPACProblemReport and CatalogConcern functions
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize <martin.renvoize>
Status: ASSIGNED --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 35287, 35616, 35625, 35628, 4461    
Bug Blocks: 34255    
Attachments: Bug 34324: Add opac_problem to source enum of tickets
Bug 34324: Add relationship aliases
Bug 34324: Add support for additional fields to /tickets
Bug 34324: Add additional_field_value to definitions
Bug 34324: API Tests
Bug 34324: Make biblio_id a nullable field
Bug 34324: Add 'Report a problem' modal
Bug 34324: Add page_url to additional_fields

Description Martin Renvoize 2023-07-20 13:08:22 UTC
I initially looked at adding the Catalog Concerns functionality into the existing OPAC Problem reports feature but quick found that troublesome. However, I still think the two sets of functionality can be merged and I designed the Catalog Concerns data structure and api's with that in mind.

We should start migrating the OPAC Problem reports functionality into the Catalog concerns 'tickets' structure as the beginnings of a new 'Enquiries' module.
Comment 1 Martin Renvoize 2023-07-20 13:15:52 UTC
*** Bug 25466 has been marked as a duplicate of this bug. ***
Comment 2 Martin Renvoize 2023-12-21 14:31:02 UTC
Only 'Bug 35287: Preparation: Extend AdditionalFields Mixin' is actually required from bug 35287 in the dependencies.. I'm tempted to split that out into it's own bug.
Comment 3 Martin Renvoize 2023-12-21 14:31:44 UTC
Created attachment 160199 [details] [review]
Bug 34324: Add opac_problem to source enum of tickets
Comment 4 Martin Renvoize 2023-12-21 14:31:46 UTC
Created attachment 160200 [details] [review]
Bug 34324: Add relationship aliases
Comment 5 Martin Renvoize 2023-12-21 14:31:49 UTC
Created attachment 160201 [details] [review]
Bug 34324: Add support for additional fields to /tickets

We need to store page_url as part of the opac_report functionality.

Rather than adding fields to the core tickets table, it makes sense to
utilise the additional_fields functionality.
Comment 6 Martin Renvoize 2023-12-21 14:31:51 UTC
Created attachment 160202 [details] [review]
Bug 34324: Add additional_field_value to definitions
Comment 7 Martin Renvoize 2023-12-21 14:31:54 UTC
Created attachment 160203 [details] [review]
Bug 34324: API Tests
Comment 8 Martin Renvoize 2023-12-21 14:31:57 UTC
Created attachment 160204 [details] [review]
Bug 34324: Make biblio_id a nullable field
Comment 9 Martin Renvoize 2023-12-21 14:31:59 UTC
Created attachment 160205 [details] [review]
Bug 34324: Add 'Report a problem' modal

This patch adds a modal for reporting opac problems. This will allow us
to remove the controller and template code for the feature.
Comment 10 Martin Renvoize 2023-12-21 14:32:02 UTC
Created attachment 160206 [details] [review]
Bug 34324: Add page_url to additional_fields
Comment 11 Martin Renvoize 2023-12-21 14:38:11 UTC
Work in progress.. still to do.
1) Re-implement/extend tickets endpoint to accept a target for who to notify by email on new submissions (we already do this for catalogue concerns, but it's hard coded to cataloguer email.. maybe we should expose it in a header as an option instead... or perhaps bing on source + audience)
2) Convert staff side interface to use the display framework built for catalog concerns.
3) Migrate existing problem reports into tickets
4) Drop the old controllers and tables