Description
Martin Renvoize (ashimema)
2023-07-20 13:08:22 UTC
*** Bug 25466 has been marked as a duplicate of this bug. *** Only 'Bug 35287: Preparation: Extend AdditionalFields Mixin' is actually required from bug 35287 in the dependencies.. I'm tempted to split that out into it's own bug. Created attachment 160199 [details] [review] Bug 34324: Add opac_problem to source enum of tickets Created attachment 160200 [details] [review] Bug 34324: Add relationship aliases Created attachment 160201 [details] [review] Bug 34324: Add support for additional fields to /tickets We need to store page_url as part of the opac_report functionality. Rather than adding fields to the core tickets table, it makes sense to utilise the additional_fields functionality. Created attachment 160202 [details] [review] Bug 34324: Add additional_field_value to definitions Created attachment 160203 [details] [review] Bug 34324: API Tests Created attachment 160204 [details] [review] Bug 34324: Make biblio_id a nullable field Created attachment 160205 [details] [review] Bug 34324: Add 'Report a problem' modal This patch adds a modal for reporting opac problems. This will allow us to remove the controller and template code for the feature. Created attachment 160206 [details] [review] Bug 34324: Add page_url to additional_fields Work in progress.. still to do. 1) Re-implement/extend tickets endpoint to accept a target for who to notify by email on new submissions (we already do this for catalogue concerns, but it's hard coded to cataloguer email.. maybe we should expose it in a header as an option instead... or perhaps bing on source + audience) 2) Convert staff side interface to use the display framework built for catalog concerns. 3) Migrate existing problem reports into tickets 4) Drop the old controllers and tables Created attachment 173580 [details] [review] Bug 34324: Add opac_problem to source enum of tickets Created attachment 173581 [details] [review] Bug 34324: Add relationship aliases Created attachment 173582 [details] [review] Bug 34324: Add support for additional fields to /tickets We need to store page_url as part of the opac_report functionality. Rather than adding fields to the core tickets table, it makes sense to utilise the additional_fields functionality. Created attachment 173583 [details] [review] Bug 34324: Add additional_field_value to definitions Created attachment 173584 [details] [review] Bug 34324: API Tests Created attachment 173585 [details] [review] Bug 34324: Make biblio_id a nullable field Created attachment 173586 [details] [review] Bug 34324: Add 'Report a problem' modal This patch adds a modal for reporting opac problems. This will allow us to remove the controller and template code for the feature. Created attachment 173587 [details] [review] Bug 34324: Add page_url to additional_fields Created attachment 173671 [details] [review] Bug 34324: Add opac_problem to source enum of tickets Created attachment 173672 [details] [review] Bug 34324: Add relationship aliases Created attachment 173673 [details] [review] Bug 34324: Add support for additional fields to /tickets We need to store page_url as part of the opac_report functionality. Rather than adding fields to the core tickets table, it makes sense to utilise the additional_fields functionality. Created attachment 173674 [details] [review] Bug 34324: Add additional_field_value to definitions Created attachment 173675 [details] [review] Bug 34324: API Tests Created attachment 173676 [details] [review] Bug 34324: Make biblio_id a nullable field Created attachment 173677 [details] [review] Bug 34324: Add 'Report a problem' modal This patch adds a modal for reporting opac problems. This will allow us to remove the controller and template code for the feature. Created attachment 173678 [details] [review] Bug 34324: Add page_url to additional_fields Created attachment 173679 [details] [review] Bug 34324: Next steps commented Created attachment 173680 [details] [review] Bug 34324: Add preview to catalog concerns summary table This patch adds the first 80 characters of the body of the message as a preview in the details field of the summary page of catalog concerns. This is to bring us more in line with what OPAC Problem reports currently displays in it's table. Rebased and ready for next steps when I get a moment |