Summary: | Duplicate patron feature | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Patrons | Assignee: | Christophe Croullebois <christophe.croullebois> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, dcook, dev_patches, gmcharlt, jonathan.druart, julian.maurice, jwagner, nengard, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://wiki.koha-community.org/wiki/Duplicate_card_button | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5575 | ||
Attachments: |
Proposed Patch
duplicated patron follow-up patch, removing test string Follow-up fix Bug 5432 [Follow-up] Duplicate patron feature [SIGNED-OFF] Bug 5432 [Follow-up] Duplicate patron feature Bug 5432 [Follow-up] Duplicate patron feature |
Description
Paul Poulain
2010-11-24 16:03:18 UTC
Created attachment 3142 [details] [review] Proposed Patch Created attachment 3146 [details] duplicated patron I tested this patch, but I can't sign off on it. There are two issues that I see in the attached file. In the top left there is 'tast' string. Also the first name isn't carried over - which might be on purpose. Also there were a few whitespace errors: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 5432 : (MT #4584b)Add duplicate support for borrowers .dotest/patch:124: trailing whitespace. <input type="text" id="initials" name="initials" size="20" value="<!-- TMPL_VAR NAME="initials" -->"<!--TMPL_IF NAME="opduplicate"--> onclick="this.value=''"<!-- /TMPL_IF --> /> .dotest/patch:252: trailing whitespace. <input type="text" id="email" name="email" size="45" value="<!-- TMPL_VAR NAME="email" -->"<!--TMPL_IF NAME="opduplicate"--> onclick="this.value=''"<!-- /TMPL_IF --> /> warning: 2 lines add whitespace errors. This patch modifies members-toolbar.inc but not circ-toolbar.inc. If we want to cover all patron-related pages we need to add the same modification to both (although the reasons for maintaining two includes my no longer be valid, something for another bug). I think not carrying over the first name is correct behavior: You're duplicating the patron because you're creating a variation on that record, not a straight duplicate. For that reason, however, I think initials and other name should not carry over either--unless I misunderstand how these fields are used? Use case is adding a member of the same family the same day.... Not wanting to re-enter all the fields. So have some kind of Help. Remeber other names and initials are not really used in France. So maybe this was not seen as a problem for us. Created attachment 3232 [details] [review] follow-up patch, removing test string pls sign-off Pushed please test This bug is mentioned in: Bug 5432 : (MT #4584b)Add duplicate support for borrowers http://lists.koha-community.org/pipermail/koha-patches/2011-February/013846.html Bug 5432 : (MT #4584b)Add duplicate support for borrowers http://lists.koha-community.org/pipermail/koha-patches/2011-February/013959.html works lovely! *** Bug 3475 has been marked as a duplicate of this bug. *** *** Bug 2602 has been marked as a duplicate of this bug. *** circ-toolbar.inc should include the same modification so that all patron-related pages have the 'duplicate' button. Created attachment 3472 [details] [review] Follow-up fix Follow up pushed, please test This bug is mentioned in: Follow-up fix for Bug 5432 - Duplicate patron feature http://lists.koha-community.org/pipermail/koha-patches/2011-March/014291.html Follow-up fix for Bug 5432 - Duplicate patron feature http://lists.koha-community.org/pipermail/koha-patches/2011-March/014286.html The 'Sort 1' field value is not erased when I put my cursor on it. Is this behavior normal? I can confirm the problem with the sort1 field on current master. I mark this reopened so this little bug doesn't get lost and can be addressed. The feature itself works. Christophe, you've been randomly choosen to check if the problem is still here and provide a fix (see comment 17 and comment 18) The bug described in comment 17 still exists in master as of 3.12 beta1 Created attachment 16894 [details] [review] Bug 5432 [Follow-up] Duplicate patron feature It is noted in Bug 5432 that during a duplicate operation one field, 'Sort1' does not automatically clear when the cursor moves into it. This patch corrects this. Edit a patron record to have data in the Sort1 and Sort2 fields. Perform a duplicate operation on this patron and confirm that the Sort1 and Sort2 fields show the information from the original patron record. When you click on each field the contents should disappear. Created attachment 17153 [details] [review] [SIGNED-OFF] Bug 5432 [Follow-up] Duplicate patron feature It is noted in Bug 5432 that during a duplicate operation one field, 'Sort1' does not automatically clear when the cursor moves into it. This patch corrects this. Edit a patron record to have data in the Sort1 and Sort2 fields. Perform a duplicate operation on this patron and confirm that the Sort1 and Sort2 fields show the information from the original patron record. When you click on each field the contents should disappear. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Add the behavior for sort2 Marked as Passed QA. Created attachment 17154 [details] [review] Bug 5432 [Follow-up] Duplicate patron feature It is noted in Bug 5432 that during a duplicate operation one field, 'Sort1' does not automatically clear when the cursor moves into it. This patch corrects this. Edit a patron record to have data in the Sort1 and Sort2 fields. Perform a duplicate operation on this patron and confirm that the Sort1 and Sort2 fields show the information from the original patron record. When you click on each field the contents should disappear. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The latest patch has been moved onto bug 9981, and I am closing this bug. |